Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Whitefacemountain Ampersand #23437

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Keyboard] Whitefacemountain Ampersand #23437

wants to merge 1 commit into from
+167 −0

Conversation

roarmstrong
Copy link

Description

Adds definitions for the Whitefacemountain Ampersand keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

lesshonor
lesshonor suggested changes Apr 8, 2024
View reviewed changes
keyboards/whitefacemountain/ampersand/ampersand.c Outdated Show resolved Hide resolved
keyboards/whitefacemountain/ampersand/ampersand.h Outdated Show resolved Hide resolved
keyboards/whitefacemountain/ampersand/info.json Outdated Show resolved Hide resolved
keyboards/whitefacemountain/ampersand/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/whitefacemountain/ampersand/README.md Outdated Show resolved Hide resolved
keyboards/whitefacemountain/ampersand/info.json Outdated Show resolved Hide resolved
keyboards/whitefacemountain/ampersand/README.md Outdated Show resolved Hide resolved
keyboards/whitefacemountain/ampersand/README.md Outdated Show resolved Hide resolved
keyboards/whitefacemountain/ampersand/info.json Outdated Show resolved Hide resolved
@waffle87 waffle87 requested a review from a team April 8, 2024 07:10
lesshonor
lesshonor approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed some ultra-minor formatting stuff, but looks good.

keyboards/whitefacemountain/ampersand/readme.md Outdated Show resolved Hide resolved
keyboards/whitefacemountain/ampersand/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@roarmstrong
Copy link
Author

I missed some ultra-minor formatting stuff, but looks good.

Thank you! I've made those edits :)

drashna
drashna approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

keyboards/whitefacemountain/ampersand/keymaps/default/keymap.c
Comment on lines +8 to +11
KC_ESC, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_MINS, KC_BSPC,
KC_TAB, KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_J, KC_K, KC_L, KC_SCLN, KC_QUOT, KC_ENT,
KC_LSFT, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, KC_RSFT,
KC_LCTL, KC_LALT, KC_LGUI, KC_SPC, KC_SPC, KC_RGUI, KC_RALT, KC_RCTL)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
KC_ESC, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_MINS, KC_BSPC,
KC_TAB, KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_J, KC_K, KC_L, KC_SCLN, KC_QUOT, KC_ENT,
KC_LSFT, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, KC_RSFT,
KC_LCTL, KC_LALT, KC_LGUI, KC_SPC, KC_SPC, KC_RGUI, KC_RALT, KC_RCTL)
KC_ESC, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_MINS, KC_BSPC,
KC_TAB, KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_J, KC_K, KC_L, KC_SCLN, KC_QUOT, KC_ENT,
KC_LSFT, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, KC_RSFT,
KC_LCTL, KC_LALT, KC_LGUI, KC_SPC, KC_SPC, KC_RGUI, KC_RALT, KC_RCTL)

@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@waffle87 waffle87 waffle87 approved these changes

@lesshonor lesshonor lesshonor approved these changes

Assignees
No one assigned
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roarmstrong @drashna @waffle87 @lesshonor