Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for wilba.tech wt65_h4 #23610

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MrLys
Copy link

@MrLys MrLys commented Apr 25, 2024

Description

Add support for the h4 based off of h1. I have not been able to make via work after flashing this, as such via is not enabled. Usevia.app did work prior to flashing. vendorId and productId is based on use-via/keyboards.

I'm unsure of who to put as maintainer in keyboards/wilba_tech/wt65_h4/readme.md

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Added support for the h4 based off of h1.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

  Add support for the h4 based off of h1. I have not been able to make
  via work after flashing this. Usevia.app did work prior to
  flashing. vendorId and productId is based on https://github.com/the-via/keyboards/blob/master/v3/wilba_tech/wt65_h4/wt65_h4.json
keyboards/wilba_tech/wt65_h4/config.h Outdated Show resolved Hide resolved
keyboards/wilba_tech/wt65_h4/info.json Show resolved Hide resolved
keyboards/wilba_tech/wt65_h4/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/wilba_tech/wt65_h4/rules.mk Outdated Show resolved Hide resolved
keyboards/wilba_tech/wt65_h4/info.json Show resolved Hide resolved
@waffle87
Copy link
Member

Also, correct me if I'm wrong, but the only difference this keyboard has with wilba_tech/wt65_h1 is the layout? If so, you should simply add the layout to that keyboard's info.json, and a keymap utilising that layout if you'd like.

@MrLys
Copy link
Author

MrLys commented Apr 25, 2024

Also, correct me if I'm wrong, but the only difference this keyboard has with wilba_tech/wt65_h1 is the layout? If so, you should simply add the layout to that keyboard's info.json, and a keymap utilising that layout if you'd like.

Not entirely sure what the exact differences are. I just used it as a baseline. But I could just as well have used the wt65_g. The productid is also different, h4 has 0x0038.
If you think that is the best approach then I’ll do that.

@waffle87
Copy link
Member

It appears these could probably all be consolidated into one. I'll have a look at it now and incorporate your layout here and reach out if you're able to test.

@waffle87
Copy link
Member

waffle87 commented Apr 25, 2024

Can you please try my refactor/wt65 branch. You can check it out locally using:

git remote add waffle https://github.com/waffle87/qmk_firmware
git fetch waffle
git checkout refactor/wt65
qmk git-submodule
qmk clean
qmk flash -kb wilba_tech/wt65_h -km iso

edit: The PR mentioned below contains the layout you are adding here, so that PR can be used instead.

@MrLys
Copy link
Author

MrLys commented Apr 26, 2024

Can you please try my refactor/wt65 branch. You can check it out locally using:

git remote add waffle https://github.com/waffle87/qmk_firmware
git fetch waffle
git checkout refactor/wt65
qmk git-submodule
qmk clean
qmk flash -kb wilba_tech/wt65_h -km iso

edit: The PR mentioned below contains the layout you are adding here, so that PR can be used instead.

Great! I’ll try to test it during the weekend.
Any idea how to make it via compatible? Based on the documentation on the usevia website this should work, but after flashing it is not recognised.

MrLys and others added 2 commits April 29, 2024 11:40
Move rules from rules.mk to info.json

Leave rules.mk empty and use properties in info.json instead

Co-authored-by: jack <0x6a73@protonmail.com>
@drashna
Copy link
Member

drashna commented Apr 29, 2024

Great! I’ll try to test it during the weekend. Any idea how to make it via compatible? Based on the documentation on the usevia website this should work, but after flashing it is not recognised.

That requires via to have the proper json merged into their repo.

@MrLys
Copy link
Author

MrLys commented Apr 30, 2024

Great! I’ll try to test it during the weekend. Any idea how to make it via compatible? Based on the documentation on the usevia website this should work, but after flashing it is not recognised.

That requires via to have the proper json merged into their repo.

I see, that it what I thought. Shouldn’t this be enough for that?

Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 15, 2024
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants