-
-
Notifications
You must be signed in to change notification settings - Fork 37.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for wilba.tech wt65_h4 #23610
base: master
Are you sure you want to change the base?
Conversation
Add support for the h4 based off of h1. I have not been able to make via work after flashing this. Usevia.app did work prior to flashing. vendorId and productId is based on https://github.com/the-via/keyboards/blob/master/v3/wilba_tech/wt65_h4/wt65_h4.json
Also, correct me if I'm wrong, but the only difference this keyboard has with |
Not entirely sure what the exact differences are. I just used it as a baseline. But I could just as well have used the wt65_g. The productid is also different, h4 has 0x0038. |
It appears these could probably all be consolidated into one. I'll have a look at it now and incorporate your layout here and reach out if you're able to test. |
Can you please try my git remote add waffle https://github.com/waffle87/qmk_firmware
git fetch waffle
git checkout refactor/wt65
qmk git-submodule
qmk clean
qmk flash -kb wilba_tech/wt65_h -km iso edit: The PR mentioned below contains the layout you are adding here, so that PR can be used instead. |
Great! I’ll try to test it during the weekend. |
Move rules from rules.mk to info.json Leave rules.mk empty and use properties in info.json instead Co-authored-by: jack <0x6a73@protonmail.com>
That requires via to have the proper json merged into their repo. |
I see, that it what I thought. Shouldn’t this be enough for that? |
Thank you for your contribution! |
Description
Add support for the h4 based off of h1. I have not been able to make via work after flashing this, as such via is not enabled. Usevia.app did work prior to flashing.
vendorId
andproductId
is based on use-via/keyboards.I'm unsure of who to put as maintainer in
keyboards/wilba_tech/wt65_h4/readme.md
Types of Changes
Issues Fixed or Closed by This PR
Checklist