Add Skyloong GK68 Pro keyboard. #23621
Open
+803
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keyboard
keymap
via
drashna
requested changes
Apr 29, 2024
OK, I do it. Co-authored-by: Drashna Jaelre <drashna@live.com>
drashna
reviewed
May 1, 2024
| }; | ||
| #endif | ||
|
|
||
| bool process_record_user(uint16_t keycode, keyrecord_t *record) { |
There was a problem hiding this comment.
This sort of functionality should really go in the keyboard level, as the default+via keymap should be pristine.
| } | ||
| return false; | ||
| # endif | ||
| case TO(0): |
There was a problem hiding this comment.
Not a fan of this. DF would be a better option for this, I think. And worst case, add a layer_clear with it, to clear all the active layers.
There was a problem hiding this comment.
If I use the TO(), I can immediately indicate the layer change when I press TO(), but when I use the DF(), I need to release the DF() to indicate the layer change. From the perspective of user experience, the TO() is better than the DF(). @drashna
madmalkav
reviewed
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Skyloong GK68 Pro keyboard
Description
Skyloong GK68 Pro is an RGB light effect keyboard with 68% keylayout.
Types of Changes
Issues Fixed or Closed by This PR
Checklist