Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Led Double Buffer #23625

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

Xelus22
Copy link
Contributor

@Xelus22 Xelus22 commented Apr 27, 2024

Description

Takes over from #22119

Adds double buffer functionality for LED matrix and RGB Matrix since RGB Matrix and LED Matrix both use the underlying drivers to set the values.

This feature is disabled by DEFAULT due to the ever present hardware of microcontrollers with very limited RAM.
It should only be enabled by testing if there is enough RAM.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Adds double buffering to all drivers that are supported in RGB/LED Matrix

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from fauxpark April 29, 2024 22:38
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the original, and seemed to work fine for the enabled drivers. But it's a bit more of a technical area, so I'm not as sure about it.

@drashna drashna requested a review from a team April 29, 2024 22:41
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 14, 2024
@drashna drashna added awaiting review breaking_change_2024q3 Targeting breaking changes Q3 2024 and removed stale Issues or pull requests that have become inactive without resolution. labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review breaking_change_2024q3 Targeting breaking changes Q3 2024 core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants