Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LED drivers: extract documentation from LED/RGB Matrix pages #23630

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

fauxpark
Copy link
Member

Description

Proper documentation for each of the supported LED driver ICs, moved out of the LED and RGB Matrix docs, because that's not where it should live.
There might be a few things here or there that I missed or are inconsistent, copy-paste errors etc. which can be tweaked later, but for the most part these are pretty much ready to go.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

docs/is31fl3236_driver.md Outdated Show resolved Hide resolved
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The very tiniest __attribute__ ((weak)) ✔️ because I didn't read every line of every doc, but what I did read was excellent.

@fauxpark fauxpark marked this pull request as ready for review May 3, 2024 12:40
@tzarc tzarc added breaking_change_2024q3 Targeting breaking changes Q3 2024 develop-fast-track Intended to be merged early in the next develop cycle. and removed breaking_change_2024q2 labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change_2024q3 Targeting breaking changes Q3 2024 develop-fast-track Intended to be merged early in the next develop cycle. documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants