Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Rename dnworks/sbl to dnworks/60percent #23683

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[Keyboard] Rename dnworks/sbl to dnworks/60percent #23683

wants to merge 3 commits into from
+14 −11

Conversation

itsme-zeix
Copy link
Contributor

Description

Renamed dnworks/sbl to dnworks/60percent due to different 60% PCBs that are electronically the same. Included the rename in data/mappings/keyboard_aliases.hjson.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support dd Data Driven Changes labels May 8, 2024
lesshonor
lesshonor approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

keyboards/dnworks/60percent/readme.md Outdated Show resolved Hide resolved
@itsme-zeix @lesshonor
Update keyboards/dnworks/60percent/readme.md
01bb515 
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
@itsme-zeix itsme-zeix mentioned this pull request May 30, 2024
Open
8 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@dunk2k dunk2k dunk2k approved these changes

@lesshonor lesshonor lesshonor approved these changes

@duncsuth-1adv duncsuth-1adv duncsuth-1adv approved these changes

Assignees
No one assigned
Labels
dd Data Driven Changes keyboard keymap stale Issues or pull requests that have become inactive without resolution. via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@itsme-zeix @drashna @dunk2k @lesshonor @duncsuth-1adv