-
-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New keymap for ryanbaekr/rb87 #23713
base: master
Are you sure you want to change the base?
Conversation
Sounds like a personal keymap to me. |
So the criteria is based on sound and not whether or not it's from the vendor? That feels wrong but it's not my call |
It's neither. A "vendor" keymap is a/the keymap that ships with the board, which may not necessarily be the same as the |
That's what this is |
Then it needs to be renamed to |
Will do on the name Combos must be enabled for repeat key. This is well documented here
It used to be the case that via keymaps had to have 4 layers. I see that is no longer the case, will do |
Compiles fine without combos enabled. Also, there's no mention on the QMK documentation of requiring combos. |
Your docs:
QMK Code: typedef struct {
keyevent_t event;
#ifndef NO_ACTION_TAPPING
tap_t tap;
#endif
#if defined(COMBO_ENABLE) || defined(REPEAT_KEY_ENABLE)
uint16_t keycode;
#endif
} keyrecord_t; Seems like combos aren't required. |
It compiles fine but the feature does not work on the board when flashed To clarify, QK_REP works, get_last_keycode() does not |
Can't reproduce this I'm afraid. Implemented your repeat keycodes identically and it works fine without any combos. case TZ_REP_2 ... TZ_REP_5:
if (record->event.pressed) {
for (int i = TZ_REP_2 - 1; i <= keycode; i++) {
tap_code16(get_last_keycode());
}
}
return false; ...where |
I believe the last commit addresses your concerns |
|
QMK is an open-source project run by volunteers. This is a low-priority item. It can wait its turn. To gain some perspective, please have a read of these links: |
Thank you for your contribution! |
Responding so this is not automatically closed |
Is there anything you need from me? |
Description
Added a new keymap for ryanbaekr/rb87 that will ship on some boards
Types of Changes
Issues Fixed or Closed by This PR
Checklist