-
-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BastardKB: upstream dilemma/4x6_4 #23816
Closed
Closed
Commits on May 28, 2024
-
Add dilemma max layer indicator (qmk#47)
* tentatively add dilemma 4x6_4 WIP untested * Add dilemma 4x6_4 WIP set max brightness to 128 pending testing migrate rgbmatrix layout macro to info.json migrate other settings to info.json add default keymap and readme add via keymap readme * 4x6_4 Remove files that shouldn't be in main KLE and Via JSONs should not be included in qmk_firmware * 4x6_4 Add RGBMATRIX coordinates in info.json WIP Still pending testing to validate coordinates Add copyright lines * 4x6_4 Change RGB matrix centre * 4x6_4 update rgb flags for outer columns * 4x6_4 add swap_hands config from Drashna * 4x6_4 explicitly set some defaults some things were only working because "processor: RP2040" defaults to GENERIC_PROMICRO_RP2040. explicitly set "board": "GENERIC_RP_RP2040" instead. correctly enable SPI0 and SPID0 instead of SPI1 * Update dilemma/readme.md * 4x6_4 migrate more items to info.json Forgot to move rgb matrix animations to info.json Didn't realise RGB_MATRIX_CENTER had an info.json mapping Missed migrating some rules.mk options to info.json * Update keyboards/bastardkb/dilemma/4x6_4/rules.mk per requested changes Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/bastardkb/dilemma/4x6_4/rules.mk per requested changes Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/bastardkb/dilemma/4x6_4/keymaps/via/config.h per requested changes Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/bastardkb/dilemma/4x6_4/keymaps/via/keymap.c per requested changes Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/bastardkb/dilemma/4x6_4/config.h per requested changes Co-authored-by: Joel Challis <git@zvecr.com> * 4x6_4/config.h formatting change per review request Co-authored-by: Drashna Jaelre <drashna@live.com> * 4x6_4/info.json formatting change per review request Co-authored-by: Drashna Jaelre <drashna@live.com> * Add layer indicators * Use predefined rgb colors for layers * Refactor layer indicators from keymap to keyboard * swap encoder volume directions for CW=volup * Revert wrong conflict solutions following review * Update keyboards/bastardkb/dilemma/4x6_4/info.json * Update keyboards/bastardkb/dilemma/4x6_4/config.h * Update keyboards/bastardkb/dilemma/4x6_4/keymaps/default/readme.md * Update keyboards/bastardkb/dilemma/4x6_4/config.h * Apply suggested changes from code review * Apply suggested changes from code review * Break the brightness interval out into defines for configurability from keymap * Formatting * Add documentation for indicator brightness boosts * narrow scope of kb-internal function * fix type of counting variable * remove unneccessary condition * Remove shutdown_user Instead of rewriting for breaking change, simply removed akin to new 3x5_3 on qmk:develop * Formatting --------- Co-authored-by: casuanoob <gms.rulz@hotmail.com> Co-authored-by: casuanoob <96005765+casuanoob@users.noreply.github.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ying Kun Zhan <yingkun@zhan.co.nl>
Configuration menu - View commit details
-
Copy full SHA for 2203858 - Browse repository at this point
Copy the full SHA 2203858View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4011485 - Browse repository at this point
Copy the full SHA 4011485View commit details -
dilemma/4x6_4: rp2040 workaround: reduce soft serial speed
burkfers committedMay 28, 2024 Configuration menu - View commit details
-
Copy full SHA for 949620b - Browse repository at this point
Copy the full SHA 949620bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6dbdbbd - Browse repository at this point
Copy the full SHA 6dbdbbdView commit details -
dilemma/4x6_4: fix double definition of split transport (info.json vs…
… config.h)
burkfers committedMay 28, 2024 Configuration menu - View commit details
-
Copy full SHA for 250ca34 - Browse repository at this point
Copy the full SHA 250ca34View commit details
Commits on Jun 11, 2024
-
dilemma/4x6_4: remove obsolete slowing-down of serial
burkfers committedJun 11, 2024 Configuration menu - View commit details
-
Copy full SHA for e4d1d95 - Browse repository at this point
Copy the full SHA e4d1d95View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.