Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up OLED last character printing #23840

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

josephscampo
Copy link

Description

On the corne OLED, there is a line which prints the last keystroke logged. As not all keystroke strings are equal in length, if keystroke N prints a shorter line than keystroke N-1, then the printed line on the OLED screen will have a few nonsensical characters at the end. My change prints a newline at the end of the keystroke log, so that any stale characters are cleared.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/crkbd/crkbd.c Outdated Show resolved Hide resolved
@josephscampo
Copy link
Author

switched to advance page, thanks for the tip @drashna. tested on my kbd 👍

drashna
drashna previously approved these changes Jun 2, 2024
@drashna drashna requested a review from a team June 2, 2024 03:18
@github-actions github-actions bot added the keymap label Jun 4, 2024
@fauxpark
Copy link
Member

fauxpark commented Jun 5, 2024

Please remove your personal keymaps from this PR.

@drashna drashna dismissed their stale review June 9, 2024 01:31

personal keymaps included in pr

@drashna drashna mentioned this pull request Jul 9, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants