Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ok #23842

Closed
wants to merge 1 commit into from
Closed

ok #23842

wants to merge 1 commit into from

Conversation

bukil
Copy link

@bukil bukil commented Jun 1, 2024 •
edited by zvecr
Loading

gitup

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@bukil
ok
c2c876f 
gitup
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 1, 2024
@zvecr zvecr added invalid pr_checklist_pending Needs changes as per the PR checklist labels Jun 1, 2024
drashna
drashna requested changes Jun 14, 2024
View reviewed changes
.vscode/settings.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert

keyboards/kodeboard/.vscode/c_cpp_properties.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed

keyboards/kodeboard/.vscode/settings.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

keyboards/kodeboard/config.h
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains no actual settings and should be removed.

keyboards/kodeboard/info.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename to keyboard.json

keyboards/kodeboard/keymaps/via/keymap_eletri.c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be removed

keyboards/kodeboard/keymaps/via/mcuconf.h
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be at the kb level, and should include a license header.

keyboards/kodeboard/keymaps/via/rules.mk
Comment on lines +1 to +20
ENCODER_MAP_ENABLE = yes
VIA_ENABLE = yes
VIAL_ENABLE = yes
ENCODER_ENABLE = yes
JOYSTICK_ENABLE = yes
JOYSTICK_DRIVER = analog
BACKLIGHT_ENABLE = yes
BACKLIGHT_DRIVER = software
OLED_ENABLE = yes
OPT_DEFS += -DHAL_USE_I2C=TRUE
BOOTMAGIC_ENABLE = yes
POINTING_DEVICE_ENABLE = yes
POINTING_DEVICE_DRIVER = analog_joystick
#OLED_DRIVER = ssd1306
#OLED_TRANSPORT = i2c
#OPT_DEFS += -DHAL_USE_I2C=TRUE
# OLED SSD1306 128x32
#ifeq ($(strip $(OLED_ENABLE)), yes)
# OLED_DRIVER_ENABLE = yes
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ENCODER_MAP_ENABLE = yes
VIA_ENABLE = yes
VIAL_ENABLE = yes
ENCODER_ENABLE = yes
JOYSTICK_ENABLE = yes
JOYSTICK_DRIVER = analog
BACKLIGHT_ENABLE = yes
BACKLIGHT_DRIVER = software
OLED_ENABLE = yes
OPT_DEFS += -DHAL_USE_I2C=TRUE
BOOTMAGIC_ENABLE = yes
POINTING_DEVICE_ENABLE = yes
POINTING_DEVICE_DRIVER = analog_joystick
#OLED_DRIVER = ssd1306
#OLED_TRANSPORT = i2c
#OPT_DEFS += -DHAL_USE_I2C=TRUE
# OLED SSD1306 128x32
#ifeq ($(strip $(OLED_ENABLE)), yes)
# OLED_DRIVER_ENABLE = yes
#endif
ENCODER_MAP_ENABLE = yes
VIA_ENABLE = yes

The encoder, backlight, oled and pointing device enable should be handled at the keyboard level.

keyboards/kodeboard/readme.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be filled out.

keyboards/kodeboard/rules.mk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be removed, and all of these can be handled by the json.

And via and encoder map are only to be enabled at the keymap level.

@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 30, 2024
@tzarc tzarc closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna requested changes

Assignees
No one assigned
Labels
invalid keyboard keymap pr_checklist_pending Needs changes as per the PR checklist stale Issues or pull requests that have become inactive without resolution. via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bukil @drashna @tzarc @zvecr