Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splitkb/kyria: remove CONVERT_TO at keyboard level #23857

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jun 3, 2024

Description

Configurator/api_tasks cannot handle converted boards, resulting in the following on the status page:

Ψ Compiling keymap with gmake -r -R -f builddefs/build_keyboard.mk -s KEYBOARD=splitkb/kyria/rev1/proton_c KEYMAP=default_configurator KEYBOARD_FILESAFE=splitkb_kyria_rev1_proton_c TARGET=splitkb_kyria_rev1_proton_c_default_configurator INTERMEDIATE_OUTPUT=.build/obj_splitkb_kyria_rev1_proton_c_default_configurator VERBOSE=false COLOR=true SILENT=false QMK_BIN="qmk" MAIN_KEYMAP_PATH_1=.build/obj_splitkb_kyria_rev1_proton_c_default_configurator MAIN_KEYMAP_PATH_2=.build/obj_splitkb_kyria_rev1_proton_c_default_configurator MAIN_KEYMAP_PATH_3=.build/obj_splitkb_kyria_rev1_proton_c_default_configurator MAIN_KEYMAP_PATH_4=.build/obj_splitkb_kyria_rev1_proton_c_default_configurator MAIN_KEYMAP_PATH_5=.build/obj_splitkb_kyria_rev1_proton_c_default_configurator KEYMAP_JSON=.build/obj_splitkb_kyria_rev1_proton_c_default_configurator/src/keymap.json KEYMAP_PATH=.build/obj_splitkb_kyria_rev1_proton_c_default_configurator/src


platforms/chibios/platform.mk:266: lib/chibios/os/hal/lib/streams/streams.mk: No such file or directory
gmake: *** No rule to make target 'lib/chibios/os/hal/lib/streams/streams.mk'.  Stop.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team June 3, 2024 06:32
@fauxpark fauxpark changed the title Branch point for 2024q3 Breaking Change. splitkb/kyria: remove CONVERT_TO at keyboard level Jun 3, 2024
@tzarc
Copy link
Member

tzarc commented Jun 3, 2024

Was audio intended to be turned off? Seems unintentional?

Did SHA1 verification and audio shows up before but not after.

@fauxpark
Copy link
Member Author

fauxpark commented Jun 3, 2024

I didn't know the converter code turned on audio... regardless there doesn't seem to be any audio-related config and none of the keymaps appear to reference it, so I think it's safe to assume it's dead weight.

@drashna
Copy link
Member

drashna commented Jun 9, 2024

there isn't enough room on the board for the speaker section, so you'd have to break it off. So no point in including audio support.

@fauxpark fauxpark merged commit 354a2e4 into qmk:develop Jun 11, 2024
3 checks passed
@fauxpark fauxpark deleted the kyria-remove-converter branch June 11, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants