Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds veilid SAO macropad #23868

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

adds veilid SAO macropad #23868

wants to merge 13 commits into from
+110 −0

Conversation

c0ldbru
Copy link
Contributor

@c0ldbru c0ldbru commented Jun 4, 2024

Description

Adds veilid SAO macropad

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr requested changes Jun 4, 2024
View reviewed changes
keyboards/rot13labs/veilid_sao/rules.mk Outdated Show resolved Hide resolved
keyboards/rot13labs/veilid_sao/info.json Outdated Show resolved Hide resolved
keyboards/rot13labs/veilid_sao/info.json Outdated Show resolved Hide resolved
keyboards/rot13labs/veilid_sao/info.json Outdated Show resolved Hide resolved
keyboards/rot13labs/veilid_sao/keymaps/default/keymap.c Outdated Show resolved Hide resolved
c0ldbru and others added 5 commits June 4, 2024 20:27
@c0ldbru @zvecr
Update keyboards/rot13labs/veilid_sao/info.json
6165d3f 
Co-authored-by: Joel Challis <git@zvecr.com>
@c0ldbru @zvecr
Update keyboards/rot13labs/veilid_sao/info.json
aed279b 
Co-authored-by: Joel Challis <git@zvecr.com>
@c0ldbru @zvecr
Update keyboards/rot13labs/veilid_sao/keymaps/default/keymap.c
7e77646 
Co-authored-by: Joel Challis <git@zvecr.com>
@c0ldbru
Delete keyboards/rot13labs/veilid_sao/rules.mk
aa02523 
removing rules.mk since its not needed
@c0ldbru
Rename info.json to keyboard.json
8568305 
renames to keyboard.json
@c0ldbru c0ldbru requested a review from zvecr June 5, 2024 15:04
@c0ldbru
Copy link
Contributor Author

c0ldbru commented Jun 7, 2024

Just checking in to see if theres anything else needed for this?

c0ldbru and others added 2 commits June 9, 2024 16:42
@c0ldbru @drashna
Update keyboards/rot13labs/veilid_sao/keymaps/default/keymap.c
09fc9e4 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@c0ldbru @drashna
Update keyboards/rot13labs/veilid_sao/keymaps/default/keymap.c
f5b98db 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@c0ldbru c0ldbru requested a review from drashna June 12, 2024 19:10
@c0ldbru
Copy link
Contributor Author

c0ldbru commented Jun 15, 2024

just checking in again to see if theres anything else needed for this to get merged?

@drashna drashna requested a review from a team June 16, 2024 14:37
c0ldbru and others added 4 commits June 16, 2024 12:12
@c0ldbru c0ldbru requested a review from fauxpark June 16, 2024 16:40
@c0ldbru @drashna
Update keyboards/rot13labs/veilid_sao/keymaps/default/keymap.c
83d7286 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@c0ldbru
Copy link
Contributor Author

c0ldbru commented Jun 23, 2024

@fauxpark @zvecr anything else needed for this PR?

@c0ldbru c0ldbru requested a review from drashna June 24, 2024 16:12
@c0ldbru
Copy link
Contributor Author

c0ldbru commented Jun 29, 2024

Just checking back in to see if anything else is needed on this?

@c0ldbru
Copy link
Contributor Author

c0ldbru commented Jul 3, 2024

@zvecr @drashna anything else needed or can this be merged in?

@sycophantic
Copy link

What is needed to get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr Awaiting requested review from zvecr

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@c0ldbru @sycophantic @drashna @fauxpark @zvecr @rot13labs