Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Update ZSA Moonlander #23911

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

[Keyboard] Update ZSA Moonlander #23911

wants to merge 4 commits into from
+358 −322

Conversation

drashna
Copy link
Member

@drashna drashna commented Jun 13, 2024

Description

  • Updates matrix code to use mcp2301x, in line with voyager code
  • Update kb code to be in line with voyager code (removing threading code!)
  • Move a lot of config into keyboard.json
  • At some point, chips were switched to STM32F303xB instead of xC. Update ld script to reflect this.

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
[Keyboard] Update ZSA Moonlander
bf6acdf 
Update LD Script

MCU was changed at some point, to help prevent too large firmware from being created...

Additional cleanup
@drashna drashna requested a review from a team June 13, 2024 06:28
zvecr
zvecr reviewed Jun 20, 2024
View reviewed changes
keyboards/zsa/moonlander/matrix.c
extern matrix_row_t matrix[MATRIX_ROWS]; // debounced values
extern matrix_row_t raw_matrix[MATRIX_ROWS]; // raw values
extern matrix_row_t matrix[MATRIX_ROWS]; // debounced values
extern matrix_row_t raw_matrix[MATRIX_ROWS]; // raw values
static matrix_row_t raw_matrix_right[MATRIX_COLS];
Copy link
Member

@zvecr zvecr Jun 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use of MATRIX_COLS here looks odd? I would expect it more to be MATRIX_ROWS / 2.

keyboards/zsa/moonlander/matrix.c Outdated Show resolved Hide resolved
keyboards/zsa/moonlander/matrix.c Outdated Show resolved Hide resolved
keyboards/zsa/moonlander/matrix.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team June 25, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr left review comments

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drashna @zvecr