Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding bongobadger for Odin 75 #23970

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adrian-stepien
Copy link

Description

Added bongobadger animation (instead of bongocat) to Odin75.
right

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@lesshonor
Copy link
Contributor

  1. User keymaps are no longer accepted into the repository as of August 27, 2023.
  2. VIA-enabled keymaps will no longer be accepted into the repository as of August 25, 2024.
  3. Instead of having to cram your addition into the existing keyboard-level file, a better method would be to only include bongocat.c if it is absolutely required by refactoring/restructuring the keyboard-level code. (Leveraging post_rules.mk may help.)

That way, anyone who prefers to have "bongoaadvark" or "bongohornet" or "bongotardigrade" could just modify their own keymap folder—rather than having to change bongocat.c, and potentially end up with frustrating git conflicts. A pull request of that nature would be an improvement to the current code, and stand a better chance at acceptance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants