Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new board km75 #23982

Open
wants to merge 55 commits into
base: master
Choose a base branch
from
Open

Add new board km75 #23982

wants to merge 55 commits into from
+445 −0

Conversation

Smartmmd
Copy link

Description

Add new board km17

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 22, 2024
@Smartmmd Smartmmd changed the title Ad Add new board km17 Jun 22, 2024
@Smartmmd Smartmmd changed the title Add new board km17 Add new board km75 Jun 22, 2024
drashna
drashna requested changes Jul 3, 2024
View reviewed changes
keyboards/mmd/km75/config.h Outdated Show resolved Hide resolved
keyboards/mmd/km75/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/mmd/km75/keymaps/via/keymap.c Show resolved Hide resolved
keyboards/mmd/km75/km75.c Outdated Show resolved Hide resolved
keyboards/mmd/km75/km75.c Outdated Show resolved Hide resolved
JackyJia73 and others added 5 commits July 3, 2024 22:41
@JackyJia73 @drashna
Update keyboards/mmd/km75/km75.c
2cd09a0 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@JackyJia73 @drashna
Update keyboards/mmd/km75/km75.c
760b5d4 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@JackyJia73 @drashna
Update keyboards/mmd/km75/config.h
b157de1 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@JackyJia73
endcoder move to keyboard.json
f29b64f
@JackyJia73
TAB change to space
d279d83
@Smartmmd Smartmmd requested a review from drashna July 3, 2024 21:14
@drashna drashna requested a review from a team July 4, 2024 20:02
@drashna
Copy link
Member

drashna commented Jul 4, 2024

Just a heads up, the PR was flagged with "needs-wireless-code", as this board may appear to be a BT/tri mode board.

As such, the code to communicate with the BT/Wireless chip needs to be present to be in compliance with the GPL licensing that QMK is under. Note, the code for the wireless chip isn't necessary, just the code to communicate with it.

@JackyJia73
Copy link
Contributor

It not a wireless board. copy a keymap from others with ble keycode by mistake. already removed
thanks

fauxpark
fauxpark requested changes Jul 5, 2024
View reviewed changes
keyboards/mmd/km75/config.h Outdated Show resolved Hide resolved
keyboards/mmd/km75/rules.mk Outdated Show resolved Hide resolved
keyboards/mmd/km75/keyboard.json Outdated Show resolved Hide resolved
keyboards/mmd/km75/km75.c Show resolved Hide resolved
zvecr
zvecr requested changes Jul 5, 2024
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, your licence headers are all over the place and should really be consistent.

keyboards/mmd/km75/keyboard.json Outdated Show resolved Hide resolved
keyboards/mmd/km75/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/mmd/km75/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/mmd/km75/keyboard.json Outdated Show resolved Hide resolved
JackyJia73 and others added 7 commits July 5, 2024 15:28
@JackyJia73 @fauxpark
Update keyboards/mmd/km75/config.h
c809973 
Co-authored-by: Ryan <fauxpark@gmail.com>
@JackyJia73 @fauxpark
Update keyboards/mmd/km75/rules.mk
83b72a7 
Co-authored-by: Ryan <fauxpark@gmail.com>
@JackyJia73 @fauxpark
Update keyboards/mmd/km75/keyboard.json
7212e61 
Co-authored-by: Ryan <fauxpark@gmail.com>
@JackyJia73 @zvecr
Update keyboards/mmd/km75/keyboard.json
634412e 
Co-authored-by: Joel Challis <git@zvecr.com>
@JackyJia73 @zvecr
Update keyboards/mmd/km75/keymaps/default/keymap.c
18ea74f 
Co-authored-by: Joel Challis <git@zvecr.com>
@JackyJia73 @zvecr
Update keyboards/mmd/km75/keymaps/via/keymap.c
bb046d9 
Co-authored-by: Joel Challis <git@zvecr.com>
@JackyJia73 @zvecr
Update keyboards/mmd/km75/keyboard.json
d06f16d 
Co-authored-by: Joel Challis <git@zvecr.com>
@JackyJia73
Copy link
Contributor

Also, your licence headers are all over the place and should really be consistent.
Sorry, I will modify.

@Smartmmd Smartmmd requested review from fauxpark and zvecr July 5, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackyJia73 JackyJia73 JackyJia73 left review comments

@drashna drashna Awaiting requested review from drashna

@fauxpark fauxpark Awaiting requested review from fauxpark

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap needs-wireless-code via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Smartmmd @drashna @JackyJia73 @fauxpark @zvecr @waffle87