Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate led_update_kb implementations to DD #23983

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Migrate led_update_kb implementations to DD #23983

merged 1 commit into from
Jun 22, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jun 22, 2024

Description

Part 3 of many.

Avoids various bad implementations, where _user funcs are not called. Also allows a few more files to be removed from the repo.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr merged commit 7824e7e into develop Jun 22, 2024
2 of 3 checks passed
@zvecr zvecr deleted the dd_indicators3 branch June 22, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants