-
-
Notifications
You must be signed in to change notification settings - Fork 37.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ProtoKeeb keyboard request #23991
base: master
Are you sure you want to change the base?
Conversation
…nto dev_branch Merging the Master branch with the dev_branch. All the Protokeeb QMK firmware development will be carried out in the dev_branch.
…dev_branch QMK dev_branch updated to the latest qmk firmware
…g to the QMK's new changelogs (renamed Protokeeb rev1 info.json to keyboard.json) and much more...
…hanges according to the PR Checklist documentation. Reorganized existing keymaps and added a new keymap.
…ed the keyboard specific configurations
Project Update:
The only problem that I have found with VIA configurator is that there is no method to implement/display the push button key and the encoder as a single entity in the VIA configurator UI. Also, to let the end users access the push button key to assign their keycodes I also modified the Protokeeb Rev1 VIA Layout JSON file which I am going to upload to the VIA GitHub repository by creating a pull request later. ProtoKeeb Rev1 VIA JSON file{
"name": "Protokeeb",
"vendorId": "0x419A",
"productId": "0x1717",
"matrix": {
"rows": 4,
"cols": 5
},
"keycodes": ["qmk_lighting"],
"menus": ["qmk_rgblight"],
"layouts": {
"keymap": [
[
{
"y": 0.3,
"x": 2,
"a": 4
},
"0,4",
{
"a": 7
},
"e0"
],
[
{
"a": 4
},
"0,0",
"0,1",
"0,2",
"0,3"
],
[
"1,0",
"1,1",
"1,2",
"1,3"
],
[
"2,0",
"2,1",
"2,2",
"2,3"
],
[
{
"c": "#aaaaaa"
},
"3,0",
{
"c": "#cccccc"
},
"3,1",
"3,2",
"3,3"
]
]
}
} |
Co-authored-by: jack <jack@pngu.org>
Co-authored-by: jack <jack@pngu.org>
Co-authored-by: jack <jack@pngu.org>
Co-authored-by: jack <jack@pngu.org>
Co-authored-by: jack <jack@pngu.org>
….json file and also formatted the C code in rev1.c file as requested by QMK Maintainer in Pull Request.
After merging the master branch of my QMK fork with the "dev_branch" to keep it updated with the latest QMK firmware changes, the QMK CI Build check in this pull request is taking significantly longer than my previous commits. It's been 11 hours and the test is still not completed. Can you please look into this issue? |
Just a heads up that all the requested changes have been made in the Protokeeb keyboard firmware files. The firmware has compiled successfully on my local machine, and I've tested everything to ensure it works as intended. Please take a moment to review the changes and then proceed with the pull request. |
You've merged incorrectly, reverting a bunch of newer changes upstream. Please fix this. |
I've merged the master branch of QMK with my QMK fork's dev_branch to address this issue. If there are any additional steps or suggestions regarding this matter, please feel free to let me know. |
Dear QMK Maintainers, I wanted to follow up on my previous communication regarding the pull request I submitted. Despite having addressed all the requested changes, I have not yet received a response from any of the QMK Maintainers. I understand that you receive numerous pull requests daily and that reviewing and responding to each one promptly may not be feasible. I kindly request your attention to further process my pull request at your earliest convenience. Thank you for your time and consideration. |
Please look at the "Files changed" tab. There are a bunch of irrelevant changes that need to be undone. |
My knowledge of git is limited. Please guide me through the steps needed to fix the issue. |
efa6e0c
to
99ae294
Compare
Fixed the issues that occurred due to the incorrect merging of branches and content. Reverted back to the commit where everything was working as intended. |
Dear QMK Maintainers @waffle87 @drashna Subject: Review Request for Pull Request I have completed all the requested changes. The firmware has been successfully compiled and everything is working as intended. I submitted a request for a re-review of my pull request 3 days ago. I kindly request the QMK maintainers to review my pull request as soon as possible. |
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
It's been two weeks since I submitted this pull request. I've made all the requested file modifications and optimizations from the QMK maintainers. I'm not sure why there's a delay in processing this pull request. Could you please either merge it or let me know if my keyboard contribution isn't considered worthy for the QMK project? Thank you! |
Description
The Protokeeb is a versatile 16-key (4 x 4) Numpad/Macropad/MIDI device designed by A-Tech Officials. It is perfect for anyone looking to get started with custom keyboards. This open-source hardware project is based on a Raspberry Pi Pico development board, making it easy to learn, build, and modify. Designed for developers and enthusiasts alike, the Protokeeb features per-key south-facing ARGB LEDs and much more.
For more information, visit the Protokeeb GitHub page.
Types of Changes
Checklist