Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend lint to reject 'blank' files #23994

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Extend lint to reject 'blank' files #23994

wants to merge 1 commit into from

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jun 25, 2024

Description

This will cover the legacy rules.mk files containing

# This file intentionally left blank

As well as the older template config.h files that only contained comments.

Code is mostly set up to also cover keymaps, but this will be enabled separately due to some files maybe having "useful" comments.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added python cli qmk cli command labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant