Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker_cmd.sh when userspace is not configured #23997

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Fix docker_cmd.sh when userspace is not configured #23997

merged 1 commit into from
Jun 26, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jun 26, 2024 •
edited
Loading

Description

Running with userspace not configured produces the following error:

./util/docker_cmd.sh: 55: cd: can't cd to None

The issue being that the None returned from QMK_USERSPACE printing out where the preceding checks expect empty string.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added python cli qmk cli command labels Jun 26, 2024
@zvecr zvecr requested review from tzarc and a team June 26, 2024 01:33
@zvecr zvecr added the bug label Jun 26, 2024
@tzarc tzarc merged commit cebe521 into master Jun 26, 2024
5 checks passed
@tzarc tzarc deleted the fix_docker_cmd branch June 26, 2024 01:34
nuphy-src pushed a commit to nuphy-src/qmk_firmware that referenced this pull request Jul 2, 2024
@zvecr @nuphy-src
Fix docker_cmd.sh when userspace is not configured (qmk#23997)
535b546
nuphy-src pushed a commit to nuphy-src/qmk_firmware that referenced this pull request Jul 2, 2024
@zvecr @nuphy-src
Fix docker_cmd.sh when userspace is not configured (qmk#23997)
db5aaa7
pcwa-ahendricks pushed a commit to wheredoesyourmindgo/serenity-qmk that referenced this pull request Jul 2, 2024
@zvecr @pcwa-ahendricks
Fix docker_cmd.sh when userspace is not configured (qmk#23997)
a19585c
AJO-Python pushed a commit to AJO-Python/qmk_firmware that referenced this pull request Jul 7, 2024
@zvecr @AJO-Python
Fix docker_cmd.sh when userspace is not configured (qmk#23997)
f49370c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
bug cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zvecr @tzarc