Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hs60/v2/hhkb: Adjust layout name #23998

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jun 26, 2024

Description

Investigating this warning which confused me as 60_hhkb is a valid community layout which should not be factored in:
⚠ hs60/v2/hhkb: Layout "LAYOUT_60_hhkb" should not contain name of keyboard.

As far as the layouts/ directory is concerned this is not an HHKB layout, which explains the warning as it is not tagged in community_layouts (thus the keyboard name itself is also incorrect).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added bug enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 26, 2024
@fauxpark fauxpark requested a review from a team June 26, 2024 04:17
@zvecr zvecr merged commit b71b81d into qmk:master Jun 26, 2024
3 checks passed
@fauxpark fauxpark deleted the hs60-hhkb-layout-name branch June 26, 2024 04:29
nuphy-src pushed a commit to nuphy-src/qmk_firmware that referenced this pull request Jul 2, 2024
nuphy-src pushed a commit to nuphy-src/qmk_firmware that referenced this pull request Jul 2, 2024
pcwa-ahendricks pushed a commit to wheredoesyourmindgo/serenity-qmk that referenced this pull request Jul 2, 2024
AJO-Python pushed a commit to AJO-Python/qmk_firmware that referenced this pull request Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants