Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tzarc/djinn: adjust layout name #24012

Merged
merged 1 commit into from
Jun 29, 2024
Merged

tzarc/djinn: adjust layout name #24012

merged 1 commit into from
Jun 29, 2024

Conversation

fauxpark
Copy link
Member

Description

⚠ tzarc/djinn/rev1: "LAYOUT_all" should be "LAYOUT" unless additional layouts are provided.
⚠ tzarc/djinn/rev2: "LAYOUT_all" should be "LAYOUT" unless additional layouts are provided.

From what I can tell this board has only one layout, which does not match any existing community layout.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 29, 2024
@fauxpark fauxpark requested review from tzarc and a team June 29, 2024 05:46
@tzarc tzarc merged commit 086e8e9 into qmk:master Jun 29, 2024
3 checks passed
@fauxpark fauxpark deleted the djinn-layout-name branch June 29, 2024 06:00
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Jul 1, 2024
@fauxpark
tzarc/djinn: adjust layout name (qmk#24012)
5a92327
nuphy-src pushed a commit to nuphy-src/qmk_firmware that referenced this pull request Jul 2, 2024
@fauxpark @nuphy-src
tzarc/djinn: adjust layout name (qmk#24012)
9d28a36
nuphy-src pushed a commit to nuphy-src/qmk_firmware that referenced this pull request Jul 2, 2024
@fauxpark @nuphy-src
tzarc/djinn: adjust layout name (qmk#24012)
adea4dc
pcwa-ahendricks pushed a commit to wheredoesyourmindgo/serenity-qmk that referenced this pull request Jul 2, 2024
@fauxpark @pcwa-ahendricks
tzarc/djinn: adjust layout name (qmk#24012)
799af7c
AJO-Python pushed a commit to AJO-Python/qmk_firmware that referenced this pull request Jul 7, 2024
@fauxpark @AJO-Python
tzarc/djinn: adjust layout name (qmk#24012)
9ef7cf3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fauxpark @tzarc @zvecr