Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

horrortroll/handwired_k552: fix RGB Matrix LED config #24014

Merged
merged 2 commits into from
Jun 29, 2024

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jun 29, 2024

Description

Moving g_led_config for this board to data driven. Since all of the LEDs appear to be marked as underglow this mismatch is not much of an issue:

⚠ horrortroll/handwired_k552: led_config: handwired_k552.c: Number of columns in row 0 (16) does not match matrix (17)

CC @HorrorTroll, would appreciate some verification if possible.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark
Copy link
Member Author

image
This looks like it might be out of order?

@HorrorTroll
Copy link
Contributor

This looks like it might be out of order?

Ahh, probably I was typo wrong order for it. Can you resolved that one for me? Thanks.

@fauxpark
Copy link
Member Author

Done. Everything else look good?

@HorrorTroll
Copy link
Contributor

Yes, everything look good now.

@fauxpark fauxpark merged commit d6bfbdb into qmk:master Jun 29, 2024
2 of 3 checks passed
@fauxpark fauxpark deleted the k552-led-config-fix branch June 29, 2024 10:56
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Jul 1, 2024
nuphy-src pushed a commit to nuphy-src/qmk_firmware that referenced this pull request Jul 2, 2024
nuphy-src pushed a commit to nuphy-src/qmk_firmware that referenced this pull request Jul 2, 2024
pcwa-ahendricks pushed a commit to wheredoesyourmindgo/serenity-qmk that referenced this pull request Jul 2, 2024
AJO-Python pushed a commit to AJO-Python/qmk_firmware that referenced this pull request Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants