Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom keycodes from nullbitsco/snap #24017

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Remove custom keycodes from nullbitsco/snap #24017

merged 1 commit into from
Jun 29, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jun 29, 2024

Description

  • Not used by any in tree keymap
  • Not implemented correctly
    • VIA custom keycode require kb block
    • KB level keycodes should not be using the user block
  • Implement shutdown logic without re-implementing QK_BOOT

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr merged commit 0947299 into develop Jun 29, 2024
3 checks passed
@zvecr zvecr deleted the snap_rm_keycodes branch June 29, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants