Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vertex/arc60h: add additional layouts #24023

Merged
merged 3 commits into from
Jul 3, 2024
Merged

vertex/arc60h: add additional layouts #24023

merged 3 commits into from
Jul 3, 2024

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jun 30, 2024 •
edited
Loading

Description

⚠ vertex/arc60h: "LAYOUT_all" should be "LAYOUT" unless additional layouts are provided.

Based on the VIA JSON: https://github.com/the-via/keyboards/blob/master/src/vertex/arc60h/arc60h.json
image

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team June 30, 2024 05:15
dunk2k
dunk2k suggested changes Jun 30, 2024
View reviewed changes
keyboards/vertex/arc60h/keyboard.json Outdated Show resolved Hide resolved
dunk2k added a commit to dunk2k/qmk_firmware that referenced this pull request Jun 30, 2024
@dunk2k
revert vertex/arc60h
8330bf0 
in favour of qmk#24023
@fauxpark @dunk2k
Update keyboards/vertex/arc60h/keyboard.json
531abb6 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@fauxpark fauxpark merged commit 33adb8c into qmk:master Jul 3, 2024
3 checks passed
@fauxpark fauxpark deleted the vertex-arc60h-add-layouts branch July 3, 2024 10:31
AJO-Python pushed a commit to AJO-Python/qmk_firmware that referenced this pull request Jul 7, 2024
@fauxpark @AJO-Python
vertex/arc60h: add additional layouts (qmk#24023)
b7d67fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@dunk2k dunk2k dunk2k approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fauxpark @drashna @dunk2k