kikoslab/kl90: add additional layouts
#24024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Jul 3, 2024
dlip
added a commit
to dlip/qmk_firmware
that referenced
this pull request
Jul 6, 2024
* upstream/master: (431 commits) `handwired/swiftrax/bumblebee`: fix layout name (qmk#24064) [docs] Update RGBLight (Underglow) keycode names (qmk#23999) `playkbtw/pk64rgb`: move RGB Matrix LED config to data driven (qmk#24062) Bump JamesIves/github-pages-deploy-action from 4.6.1 to 4.6.3 (qmk#24063) `kbdfans/baguette66`: fix layout name (qmk#24061) Add support for Equinox XL (qmk#23695) `kakunpc/rabbit_capture_plan`: add additional layouts (qmk#24059) `kakunpc/angel64`: add additional layouts (qmk#24058) `ash_xiix`: add additional layouts (qmk#24057) `handwired/tkk`: fix layout name (qmk#24056) `dc01/arrow`: fix layout name (qmk#24025) Add Sleepy Craft Studios Sleepy Keeb Split (qmk#23844) `salicylic_acid3/setta21`: fix RGB Matrix LED config (qmk#24041) `kikoslab/kl90`: add additional layouts (qmk#24024) Fixes duplicate pid/vid for sofle_choc (qmk#24030) [Keyboard] Addition of EC 60X (qmk#24028) [Keyboard] Add chlx lfn merro (qmk#24026) monsgeek/m5: make numlock and capslock LEDs work (qmk#24027) [Keyboard] Add Ashwing66 (qmk#24031) Minimum python version listing. (qmk#23989) ...
AJO-Python
pushed a commit
to AJO-Python/qmk_firmware
that referenced
this pull request
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the VIA JSON, the placement of the ISO
\|key was incorrect.This board also comes in hotswap and solder flavours, the former of which only supports ANSI. It should probably therefore be split in two, but for the moment I've just added both layout sets to the existing
keyboard.json.This page was useful in determining the possible layouts of both versions: https://mattj.io/posts/2021-12-16-kikos-lab-kl-90-fe-unbox/
Types of Changes
Issues Fixed or Closed by This PR
Checklist