Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[keyboard] Add Linx3 FAve65S #24034

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

[keyboard] Add Linx3 FAve65S #24034

wants to merge 16 commits into from
+864 −0

Conversation

eerraa
Copy link
Contributor

@eerraa eerraa commented Jul 2, 2024

Linx3 FAve65S

Description

65% layout keyboard with blocker, Powered by RP2040.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@eerraa
FAve65S
83749d8 
FAve65S
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 2, 2024
@eerraa eerraa changed the title [keyboard] add Linx3 FAve65S [keyboard] Add Linx3 FAve65S Jul 2, 2024
@eerraa
Remove rules.mk
16c99c0 
Remove rules.mk
@eerraa
Change readme.md
58e020b 
Change readme.md
@waffle87 waffle87 requested a review from a team July 2, 2024 17:02
dunk2k
dunk2k suggested changes Jul 2, 2024
View reviewed changes
keyboards/era/linx3/fave65s/readme.md Show resolved Hide resolved
keyboards/era/linx3/fave65s/keyboard.json Outdated Show resolved Hide resolved
keyboards/era/linx3/fave65s/fave65s.c Outdated Show resolved Hide resolved
keyboards/era/linx3/fave65s/config.h Outdated Show resolved Hide resolved
keyboards/era/linx3/fave65s/keyboard.json Outdated Show resolved Hide resolved
keyboards/era/linx3/fave65s/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/era/linx3/fave65s/keymaps/via/keymap.c Outdated Show resolved Hide resolved
eerraa and others added 7 commits July 3, 2024 10:11
@eerraa
Update Physical location of LEDs
3321e3d 
Update Physical location of LEDs
@eerraa @dunk2k
Update keyboards/era/linx3/fave65s/fave65s.c
1d056c5 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@eerraa @dunk2k
Update keyboards/era/linx3/fave65s/keymaps/default/keymap.c
0f32545 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@eerraa @dunk2k
Update keyboards/era/linx3/fave65s/keymaps/via/keymap.c
bdab180 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@eerraa @dunk2k
Update keyboards/era/linx3/fave65s/config.h
921736f 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@eerraa @dunk2k
Update keyboards/era/linx3/fave65s/keyboard.json
2658a42 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@eerraa
Update layout
9edfcbc 
Update layout
@eerraa eerraa requested a review from dunk2k July 3, 2024 02:19
@eerraa @dunk2k
Update keyboards/era/linx3/fave65s/keyboard.json
5cd046b 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
dunk2k
dunk2k suggested changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes Left Shift cluster for ISO layouts

keyboards/era/linx3/fave65s/keyboard.json Outdated Show resolved Hide resolved
keyboards/era/linx3/fave65s/keyboard.json Outdated Show resolved Hide resolved
keyboards/era/linx3/fave65s/keyboard.json Outdated Show resolved Hide resolved
keyboards/era/linx3/fave65s/keyboard.json Outdated Show resolved Hide resolved
eerraa and others added 4 commits July 4, 2024 00:48
@eerraa @dunk2k
Update keyboards/era/linx3/fave65s/keyboard.json
6109802 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@eerraa @dunk2k
Update keyboards/era/linx3/fave65s/keyboard.json
cd1fffe 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@eerraa @dunk2k
Update keyboards/era/linx3/fave65s/keyboard.json
6eedc06 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@eerraa @dunk2k
Update keyboards/era/linx3/fave65s/keyboard.json
5fede74 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@eerraa
Copy link
Contributor Author

eerraa commented Jul 3, 2024

fixes Left Shift cluster for ISO layouts

Oh, I missed that ISO changes not only Enter but also Left Shift.
Thank you so much for even editing it yourself.

@eerraa
add photo
f556a35 
add photo
@eerraa eerraa requested a review from dunk2k July 5, 2024 07:19
@eerraa
Copy link
Contributor Author

eerraa commented Jul 5, 2024 •
edited
Loading

@dunk2k
Added an image of the PCB. :)
Thank you for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark left review comments

@waffle87 waffle87 waffle87 approved these changes

@dunk2k dunk2k dunk2k approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eerraa @fauxpark @waffle87 @dunk2k