Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gmkb keyboard #24039

Closed
wants to merge 5 commits into from
Closed

Add gmkb keyboard #24039

wants to merge 5 commits into from

Conversation

diana202402
Copy link

Description

Add gmkb keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 3, 2024
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to be attempting to add this as a personal project, rather than alongside the existing keyboards/doio/ keyboards?

@zvecr zvecr added the invalid label Jul 3, 2024
keyboards/diana/gmkb/keyboard.json Show resolved Hide resolved
keyboards/diana/gmkb/rules.mk Outdated Show resolved Hide resolved
@diana202402
Copy link
Author

You seem to be attempting to add this as a personal project, rather than alongside the existing keyboards/doio/ keyboards?

@zvecr Hi, I can't revert the files I previously modified,
So I used a new personal account to update the code.

@zvecr
Copy link
Member

zvecr commented Jul 3, 2024

Hi, I can't revert the files I previously modified,
So I used a new personal account to update the code.

That doesn't make any sense.

It would need to be keyboards/doio/nindoio (or something similar). Anything associated to your accounts username is invalid.

@diana202402
Copy link
Author

Hi, I can't revert the files I previously modified,
So I used a new personal account to update the code.

That doesn't make any sense.

It would need to be keyboards/doio/nindoio (or something similar). Anything associated to your accounts username is invalid.

@zvecr Hi ,if I

Hi, I can't revert the files I previously modified,
So I used a new personal account to update the code.

That doesn't make any sense.

It would need to be keyboards/doio/nindoio (or something similar). Anything associated to your accounts username is invalid.

@zvecr HI, I have reverted the pull request as DOIO account.I clesed this pull request. Thank you for your help.

@diana202402 diana202402 closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants