Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add et7233 keyboard #24046

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add et7233 keyboard #24046

wants to merge 3 commits into from
+412 −0

Conversation

yangzheng20003
Copy link

@yangzheng20003 yangzheng20003 commented Jul 4, 2024 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 4, 2024
@waffle87 waffle87 requested a review from a team July 4, 2024 19:39
zvecr
zvecr requested changes Jul 4, 2024
View reviewed changes
keyboards/et/et7233/et7233.c Outdated
Comment on lines 17 to 84
{0, CS15_SW1, CS14_SW1, CS13_SW1 }, // 0 Esc
{0, CS15_SW2, CS14_SW2, CS13_SW2 }, // 1 F1
{0, CS15_SW3, CS14_SW3, CS13_SW3 }, // 2 F2
{0, CS15_SW4, CS14_SW4, CS13_SW4 }, // 3 F3
{0, CS15_SW5, CS14_SW5, CS13_SW5 }, // 4 F4
{0, CS15_SW6, CS14_SW6, CS13_SW6 }, // 5 F5
{0, CS15_SW7, CS14_SW7, CS13_SW7 }, // 6 F6
{0, CS15_SW8, CS14_SW8, CS13_SW8 }, // 7 F7
{0, CS15_SW9, CS14_SW9, CS13_SW9 }, // 8 F8
{0, CS15_SW10, CS14_SW10, CS13_SW10 }, // 9 F9
{0, CS15_SW11, CS14_SW11, CS13_SW11 }, // 10 F10
{0, CS15_SW12, CS14_SW12, CS13_SW12 }, // 11 F11
{0, CS18_SW2, CS17_SW2, CS16_SW2 }, // 12 F12
{0, CS18_SW3, CS17_SW3, CS16_SW3 }, // 13 MUTE

{0, CS12_SW1, CS11_SW1, CS10_SW1 }, // 14 PSCR
{0, CS12_SW2, CS11_SW2, CS10_SW2 }, // 15 SCRL
{0, CS12_SW3, CS11_SW3, CS10_SW3 }, // 16 PAUSE
{0, CS12_SW4, CS11_SW4, CS10_SW4 }, // 17 `~
{0, CS12_SW5, CS11_SW5, CS10_SW5 }, // 18 1
{0, CS12_SW6, CS11_SW6, CS10_SW6 }, // 19 2
{0, CS12_SW7, CS11_SW7, CS10_SW7 }, // 20 3
{0, CS12_SW8, CS11_SW8, CS10_SW8 }, // 21 4
{0, CS12_SW9, CS11_SW9, CS10_SW9 }, // 22 5
{0, CS12_SW10, CS11_SW10, CS10_SW10 }, // 23 6
{0, CS12_SW11, CS11_SW11, CS10_SW11 }, // 24 7
{0, CS12_SW12, CS11_SW12, CS10_SW12 }, // 25 8
{0, CS18_SW4, CS17_SW4, CS16_SW4 }, // 26 9
{0, CS18_SW5, CS17_SW5, CS16_SW5 }, // 27 0

{0, CS1_SW1, CS2_SW1, CS3_SW1 }, // 28 -_
{0, CS1_SW2, CS2_SW2, CS3_SW2 }, // 29 =+
{0, CS1_SW3, CS2_SW3, CS3_SW3 }, // 30 BSPC
{0, CS1_SW4, CS2_SW4, CS3_SW4 }, // 31 INS
{0, CS1_SW5, CS2_SW5, CS3_SW5 }, // 32 HOME
{0, CS1_SW6, CS2_SW6, CS3_SW6 }, // 33 PGUP
{0, CS1_SW7, CS2_SW7, CS3_SW7 }, // 34 Tab
{0, CS1_SW8, CS2_SW8, CS3_SW8 }, // 35 Q
{0, CS1_SW9, CS2_SW9, CS3_SW9 }, // 36 W
{0, CS1_SW10, CS2_SW10, CS3_SW10 }, // 37 E
{0, CS1_SW11, CS2_SW11, CS3_SW11 }, // 38 R
{0, CS1_SW12, CS2_SW12, CS3_SW12 }, // 39 T
{0, CS18_SW6, CS17_SW6, CS16_SW6 }, // 40 Y
{0, CS18_SW7, CS17_SW7, CS16_SW7 }, // 41 U

{0, CS4_SW1, CS5_SW1, CS6_SW1 }, // 42 I
{0, CS4_SW2, CS5_SW2, CS6_SW2 }, // 43 O
{0, CS4_SW3, CS5_SW3, CS6_SW3 }, // 44 P
{0, CS4_SW4, CS5_SW4, CS6_SW4 }, // 45 [{
{0, CS4_SW5, CS5_SW5, CS6_SW5 }, // 46 ]}
{0, CS4_SW6, CS5_SW6, CS6_SW6 }, // 47 \|
{0, CS4_SW7, CS5_SW7, CS6_SW7 }, // 48 Del
{0, CS4_SW8, CS5_SW8, CS6_SW8 }, // 49 End
{0, CS4_SW9, CS5_SW9, CS6_SW9 }, // 50 PGDN
{0, CS4_SW10, CS5_SW10, CS6_SW10 }, // 51 Caps
{0, CS4_SW11, CS5_SW11, CS6_SW11 }, // 52 A
{0, CS4_SW12, CS5_SW12, CS6_SW12 }, // 53 S
{0, CS18_SW8, CS17_SW8, CS16_SW8 }, // 54 D
{0, CS18_SW9, CS17_SW9, CS16_SW9 }, // 55 F

{0, CS7_SW1, CS8_SW1, CS9_SW1 }, // 56 G
{0, CS7_SW2, CS8_SW2, CS9_SW2 }, // 57 H
{0, CS7_SW3, CS8_SW3, CS9_SW3 }, // 58 J
{0, CS7_SW7, CS8_SW7, CS9_SW7 }, // 59 K
{0, CS7_SW11, CS8_SW11, CS9_SW11 }, // 60 L
{0, CS7_SW12, CS8_SW12, CS9_SW12 }, // 61 ;:
{0, CS18_SW10, CS17_SW10, CS16_SW10 }, // 62 '
{0, CS18_SW11, CS17_SW11, CS16_SW11 } // 63 #~
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are using the deprecated defines, the correct ones being in the format SW1_CS1.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your correction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 left review comments

@zvecr zvecr zvecr requested changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yangzheng20003 @drashna @zvecr @waffle87