Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and updates to docs #2611

Merged
merged 9 commits into from
Mar 25, 2018
Merged

Fixes and updates to docs #2611

merged 9 commits into from
Mar 25, 2018

Conversation

drashna
Copy link
Member

@drashna drashna commented Mar 25, 2018

Fixes a number of issues (such as links and formatting) and adds some updates/clarifications for other docs.

@@ -34,6 +34,8 @@ This is a C header file that is one of the first things included, and will persi
## `config.h` Options

### Hardware Options
====================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are conflicting styles. The ### indicates a level 3 header, while the ==== underneath indicates a level 1 header.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem. Will change.

Just really want a good way to make sure these headers are LINKABLE. And easily so.
Because apparently, no link comes up for these... and it would make things SOO much easier.

@@ -2,7 +2,7 @@

Your keymap can include keycodes that are more advanced than normal, for example shifted keys. This page documents the functions that are available to you.

### Assigning Custom Names
## Assigning Custom Names
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These level 3 headers were deliberate so they wouldn't make the TOC too confusing. With level 2 headers the TOC became big and hard to follow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured it was something like that....
And H3 ... get no links (nor love, apparently)

@drashna
Copy link
Member Author

drashna commented Mar 25, 2018

Is there some way to get the H3 stuff to be linkable?

Some pages are "okay", but docs like the Config options is ... absolutely atrocious for references:
https://docs.qmk.fm/config_options.html

@skullydazed
Copy link
Member

skullydazed commented Mar 25, 2018

For the config options case I think we can remove the config.h Options and rules.mk Options headers and move those H3's up to H2. I think at the time I thought there would be more structure needed there, but looking at this today I think I agree with you that those headings should be in the TOC.

@drashna
Copy link
Member Author

drashna commented Mar 25, 2018

Done. And I think that should help with ... well helping people.

And if we could move over to the beta version .... that would fix many of the issues with linkability.

@skullydazed skullydazed merged commit 07b90db into qmk:master Mar 25, 2018
@skullydazed
Copy link
Member

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants