Add Canoe support #3063
Merged
Add Canoe support #3063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested changes
May 28, 2018
keyboards/canoe/canoe.h
Outdated
|
|
||
| #include "quantum.h" | ||
|
|
||
| #define KEYMAP( \ |
| along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| #include "canoe.h" |
There was a problem hiding this comment.
Could you replace all of the includes here with just #include QMK_KEYBOARD_H?
|
|
||
| const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | ||
|
|
||
| [_BL] = KEYMAP( |
There was a problem hiding this comment.
Please change all of the KEYMAPs to LAYOUT.
drashna
approved these changes
May 28, 2018
|
Awesome, thanks! |
carlpehrson
pushed a commit
to carlpehrson/qmk_firmware
that referenced
this pull request
May 30, 2018
* Adding Canoe support * fix readme * Remove usless comment * fixing issues
tenderlove
added a commit
to tenderlove/qmk_firmware
that referenced
this pull request
Aug 5, 2018
* master: (622 commits) Refactor and Configurator updates for B.mini (qmk#3081) qwerty_code_friendly: add numbers keys (qmk#3078) Switch to noeeprom variants of rgb fns (qmk#3077) Add bpruitt-goddard Ergodox Layout (qmk#3080) Add and fix _noeeprom functions to many of the RGB Underglow functions (qmk#3070) Keymap fixes (qmk#3074) Refactor and Configurator updates for Woodkeys/NovelKeys Big Series (qmk#3073) Kbd8x backlight support (qmk#3069) Refactor and Configurator updates for Bantam44 (qmk#3071) Configurator updates for Atreus/Atreus62 (qmk#3065) fix a few simple typos (qmk#3068) Update Canoe ps2avr board (qmk#3066) Indicator led support for KBD8X (qmk#3064) Fix nyquist (and other splits using D2 in debouncing) (qmk#3067) Add Canoe support (qmk#3063) Refactor and Configurator updates for AMJ Pad (qmk#3060) Refresh & improve leader documentation page (qmk#2990) Refactor and Configurator updates for AMJ60 (qmk#3055) Adding guidoism's planck layouts (qmk#3059) Add mtdjr keymaps for Iris, Let's Split, TADA68, XD75, and handwired dox (qmk#3058) ...
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
* Adding Canoe support * fix readme * Remove usless comment * fixing issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the Canoe keyboard.