[Let's Split] Add ability to write additional code in matrix scan loop on slave. #3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Um... Any ideas why does the build failed? It's not my code that breaks it. |
|
Thanks! |
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds possibility to define custom code on slave part of the Let's Split keyboard within keymap scope without altering the keyboard scope code. This was achieved by defining a weak attribute
matrix_slave_scan_user(void)that will be called duringmatrix_slave_scan(void).This allows to perform some actions on the slave part by defining a
matrix_slave_scan_user(void)function within your keymap. I've tested this to make slave's TX LED blink every 100ms.This idea was briefly discussed on Gitter (thanks @drashna)