Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of hard brigtness limit for RGB_Matrix #3299

Merged
merged 3 commits into from
Jul 3, 2018
Merged

Addition of hard brigtness limit for RGB_Matrix #3299

merged 3 commits into from
Jul 3, 2018

Conversation

yiancar
Copy link
Contributor

@yiancar yiancar commented Jul 3, 2018

  • Added a define "RGB_MATRIX_MAXIMUM_BRIGHTNESS" to enable hard limiting the maximum brightness for rgb_matrix
  • Used the above define to limit the maximum brigthness of HS60 for better stability

@yiancar
Addition of hard brigtness limit for RGB_Matrix
ea063e2 
- Added a define "RGB_MATRIX_MAXIMUM_BRIGHTNESS" to enable hard limiting the maximum brightness for rgb_matrix
- Used the above define to limit the maximum brigthness of HS60 for better stability
@yiancar
Copy link
Contributor Author

yiancar commented Jul 3, 2018

Please let me know if you approve of this and I will be adding documentation as well!

drashna
drashna reviewed Jul 3, 2018
View reviewed changes
quantum/rgb_matrix.c Outdated
@@ -41,6 +41,10 @@ rgb_config_t rgb_matrix_config;
#define EECONFIG_RGB_MATRIX EECONFIG_RGBLIGHT
#endif

#ifndef RGB_MATRIX_MAXIMUM_BRIGHTNESS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be a good to limit the value too, so that we can't have a value higher than 255.

so maybe instead, something like:

#if !defined(RGB_MATRIX_MAXIMUM_BRIGHTNESS) || RGB_MATRIX_MAXIMUM_BRIGHTNESS > 255
    #define RGB_MATRIX_MAXIMUM_BRIGHTNESS 255
#endif

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool yea agreed!

@drashna drashna requested a review from jackhumbert July 3, 2018 16:50
@jackhumbert
Copy link
Member

jackhumbert commented Jul 3, 2018 •
edited
Loading

Perfect - thanks folks!

@jackhumbert jackhumbert merged commit a7df902 into qmk:master Jul 3, 2018
@yiancar yiancar deleted the RGB_matrix_backlight_limit branch July 10, 2018 15:07
alexey-danilov pushed a commit to alexey-danilov/qmk_firmware that referenced this pull request Jul 27, 2018
@yiancar
Addition of hard brigtness limit for RGB_Matrix (qmk#3299)
2d92783 
* Addition of hard brigtness limit for RGB_Matrix

- Added a define "RGB_MATRIX_MAXIMUM_BRIGHTNESS" to enable hard limiting the maximum brightness for rgb_matrix
- Used the above define to limit the maximum brigthness of HS60 for better stability

* Added docs for new rgb_matrix define

* Addition of check for maximum brightness
tenderlove added a commit to tenderlove/qmk_firmware that referenced this pull request Aug 5, 2018
@tenderlove
Merge branch 'master' into merging
e1022c5 
* master: (174 commits)
  Addition of hard brigtness limit for RGB_Matrix (qmk#3299)
  Phantom refactor and Configurator update (qmk#3285)
  Fixed pin for RGB on lets_split/sockets keyboard (qmk#3284)
  qwerty_code_friendly: update for renamed macro (qmk#3283)
  defaulted to 5 rows when HELIX_ROWS is not defined (qmk#3282)
  Omnikey Blackheart refactor (qmk#3280)
  OK60 Refactor and Configurator support (qmk#3279)
  Nyquist Configurator support and keymap refactor (qmk#3278)
  Novelpad refactor and Configurator support (qmk#3276)
  Nano refactor and Configurator update (qmk#3275)
  Helix five rows jis (qmk#3274)
  Miuni32 refactor and Configurator support (qmk#3273)
  Mitosis refactor and Configurator support (qmk#3271)
  Helix fix configrator problem (qmk#3270)
  ErgoDash Hardware Update (qmk#3269)
  Helix shrink config (qmk#3268)
  readme update to wanleg layout (qmk#3266)
  Maxr1998's contra layout (qmk#3267)
  Add XD75 keymap (qmk#3263)
  add QMK DFU make option to gherkin, and bootloader replacement instructions (qmk#3253)
  ...
ChrissiQ pushed a commit to ChrissiQ/qmk_firmware that referenced this pull request Sep 25, 2018
@yiancar @ChrissiQ
Addition of hard brigtness limit for RGB_Matrix (qmk#3299)
2b072ba 
* Addition of hard brigtness limit for RGB_Matrix

- Added a define "RGB_MATRIX_MAXIMUM_BRIGHTNESS" to enable hard limiting the maximum brightness for rgb_matrix
- Used the above define to limit the maximum brigthness of HS60 for better stability

* Added docs for new rgb_matrix define

* Addition of check for maximum brightness
yamad pushed a commit to yamad/qmk_firmware that referenced this pull request Apr 10, 2019
@yiancar @yamad
Addition of hard brigtness limit for RGB_Matrix (qmk#3299)
bb546ae 
* Addition of hard brigtness limit for RGB_Matrix

- Added a define "RGB_MATRIX_MAXIMUM_BRIGHTNESS" to enable hard limiting the maximum brightness for rgb_matrix
- Used the above define to limit the maximum brigthness of HS60 for better stability

* Added docs for new rgb_matrix define

* Addition of check for maximum brightness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna left review comments

@jackhumbert jackhumbert Awaiting requested review from jackhumbert

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yiancar @jackhumbert @drashna