Convert Iris to use SPLIT_KEYBOARD #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nooges Does this look okay to you? |
|
I'm going to run a diff between the matrix code and mine first to make sure my recent changes got picked up. So, gimme a day to check it out.
… On Jul 21, 2018, at 11:54 AM, Drashna Jaelre ***@***.***> wrote:
@nooges Does this look okay to you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Awesome, thanks! |
alexey-danilov
pushed a commit
to alexey-danilov/qmk_firmware
that referenced
this pull request
Aug 3, 2018
* convert iris to split-common * Fix build error
filoxo
pushed a commit
to filoxo/qmk_firmware
that referenced
this pull request
Aug 27, 2018
* convert iris to split-common * Fix build error
ChrissiQ
pushed a commit
to ChrissiQ/qmk_firmware
that referenced
this pull request
Sep 25, 2018
* convert iris to split-common * Fix build error
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
* convert iris to split-common * Fix build error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @drashna, I converted the rules.mk for Iris to use SPLIT_KEYBOARD. Had to modify the
quantum/split_common/matrix.cto fix a build error.