Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PCBDOWN variants for Atreus keyboard #3735

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Conversation

kensanata
Copy link
Contributor

No description provided.

@technomancy
Copy link
Contributor

Good catch; thanks for this!

@drashna
Copy link
Member

drashna commented Aug 24, 2018

Thanks!

@drashna drashna merged commit 37d3055 into qmk:master Aug 24, 2018
muramasa64 pushed a commit to muramasa64/qmk_firmware that referenced this pull request Aug 25, 2018
alexey-danilov pushed a commit to alexey-danilov/qmk_firmware that referenced this pull request Sep 6, 2018
ChrissiQ pushed a commit to ChrissiQ/qmk_firmware that referenced this pull request Sep 25, 2018
yamad pushed a commit to yamad/qmk_firmware that referenced this pull request Apr 10, 2019
@RagingRoosevelt
Copy link
Contributor

I'm interested in doing the legwork to get the online configurator to make use of this. I believe this could be accomplished by adding a Layout profile to the Atreus's config.h file such as LAYOUT_AStar. This doesn't take advantage of the PCBDOWN=yes make flag but it seems like using that would require changes to the way the configurator handles build tasks. Is this something worth pursuing and does this seem like an acceptable way to go about the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants