Update logo and commonize it #4151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
reviewed
Oct 17, 2018
| SWAP_HANDS_ENABLE = no # Enable one-hand typing | ||
| RGBLIGHT_ENABLE = yes # Enable WS2812 RGB underlight. Do not enable this with audio at the same time. | ||
| SWAP_HANDS_ENABLE = no # Enable one-hand typing | ||
| LOCAL_GLCDFONT = no # use each keymaps "glcdfont.c" insted of "keymaps/default/glcdfont.c" |
There was a problem hiding this comment.
This doesn't do anything.
It's not being processed, basically.
You'd need something like this in the rules.mk here:
ifeq ($(strip $(LOCAL_GLCDFONT)), yes)
OPT_DEFS += -DLOCAL_GLCDFONT
endif
|
Actually, wouldn't it be better to move the glcdfont.c to the "lib" folder, and just add it to the "SRC" value of the rules.mk in the keymap folders? |
|
It's sounds good.
Compile error Sorry I'm unfamiliar with C lang. Can you give me advice? |
|
Oh, that's ... odd. It's that it's being defined "but not used". Which is odd, as I compiled it on my system, and it works just fine. But worst case, wrap it in |
…les.mk in the keymap folders
foostan
commented
Oct 19, 2018
|
Just to make sure, this is good to go now? |
|
yes please 😄 |
|
Done! |
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Oct 27, 2018
* Update logo and commonize it * Move the glcdfont.c to the lib and add it to the SRC values of the rules.mk in the keymap folders * Add static
rseymour
pushed a commit
to rseymour/qmk_firmware
that referenced
this pull request
Mar 13, 2019
* Update logo and commonize it * Move the glcdfont.c to the lib and add it to the SRC values of the rules.mk in the keymap folders * Add static
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
* Update logo and commonize it * Move the glcdfont.c to the lib and add it to the SRC values of the rules.mk in the keymap folders * Add static
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created the
cornelogo.So I updated the logo of OLED screen.
before
after