Lily58 default keymap fix / add keymap #4190
Conversation
| */ | ||
| #pragma once | ||
|
|
||
| #include "config.h" |
There was a problem hiding this comment.
This line is not actually needed, and should be removed.
Specifically, the build script automatically includes all of the config.h files, so this is not necessary.
|
|
||
|
|
||
|
|
||
| void persistent_default_layer_set(uint16_t default_layer) { |
There was a problem hiding this comment.
Could you remove this function?
It's been depreciated in favor of the set_single_persistent_default_layer function (which is a core function).
https://docs.qmk.fm/#/ref_functions?id=setting-the-persistent-default-layer
| @@ -1,9 +1,7 @@ | |||
| SRC += matrix.c \ | |||
| i2c.c \ | |||
| split_util.c \ | |||
| serial.c \ | |||
| ssd1306.c | |||
There was a problem hiding this comment.
Is there a reason for removing this?
| @@ -1,330 +0,0 @@ | |||
| #ifdef SSD1306OLED | |||
There was a problem hiding this comment.
Was there a reason for removing this?
|
@drashna |
|
Okay. Thanks for the clarification. |
* keymap fix/add * keymap fix * file fix * typo fix
* keymap fix/add * keymap fix * file fix * typo fix
* keymap fix/add * keymap fix * file fix * typo fix
* keymap fix/add * keymap fix * file fix * typo fix
No description provided.