Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helix serial.c, split_scom.c bug fix and update #4191

Merged
merged 21 commits into from
Oct 22, 2018
Merged

Helix serial.c, split_scom.c bug fix and update #4191

merged 21 commits into from
Oct 22, 2018

Conversation

mtei
Copy link
Contributor

@mtei mtei commented Oct 21, 2018

Bug fix serial.c and RGB LED animation conflict error

Detection was added when the delay to enter the interrupt processing routine is large.

Fix split_scomm.c error handling

split_scomm.c did not properly inform matrix.c of errors reported by serial.c.

Change serial.c configuration form

OLD configuration

#define SERIAL_PIN_DDR DDRD
#define SERIAL_PIN_PORT PORTD
#define SERIAL_PIN_INPUT PIND
#define SERIAL_PIN_MASK _BV(PD2)
#define SERIAL_PIN_INTERRUPT INT2_vect

NEW configuration

#define SOFT_SERIAL_PIN D2

Check the operation of the usable port of serial.c.

confirm PD0, PD1, PD2, PD3, PE6 is work.

@mtei
helix/serial.c add support PD1,PD3,PE6 and configuration simplify
68d6ba1
@mtei
Add comment about ATmega32U4 I2C
4013bee
@mtei
Add compile time check for ATmega32U4 I2C
c31e842
@mtei
change TAB code to 8 SPACE code
6573bd9
@mtei
Helix serial.c PORTD,PD0 test. OK
db9ba00 
  OK PD0
  -  PD1
  OK PD2
  -  PD3
  -  PE6
@mtei
Helix serial.c PORTD,PD1 test. OK
467ca31 
   OK PD0
   OK PD1
   OK PD2
   -  PD3
   -  PE6
@mtei
Helix serial.c PORTD,PD3 test. OK
907114f 
   OK PD0
   OK PD1
   OK PD2
   OK PD3
   -  PE6
@mtei
Helix serial.c PORTE,PD6 test. OK
1592ba1 
   OK PD0
   OK PD1
   OK PD2
   OK PD3
   OK PE6
@mtei
Helix serial.c: PD0,PD1,PD3,PE6 all test end
ad89c6a
@mtei
Helix serial.c: rename SOFT_SERIAL_PORT to SOFT_SERIAL_PIN
1ffc26f
@mtei
Helix serial.c add debug code
0997d1c
@mtei
Helix serial.c: add transaction ID range check
c987264
@mtei
Helix serial.c debug code update
edf16d3
@mtei
Helix serial.c debug code update
06f6ebb
@mtei
Helix serial.c: Strict checking of the value of tid.
c34d852
@mtei
adjust the delay of serial.c
2e47145
@mtei
Helix serial.c: remove debug code
d77b3dd
@mtei
remove EXTRAFLAGS += -DCONSOLE_ENABLE from five_rows/rules.mk
359d219 
tmk_core/common.mk has
 >ifeq ($(strip $(CONSOLE_ENABLE)), yes)
 >   TMK_COMMON_DEFS += -DCONSOLE_ENABLE
@mtei
Fix error handling in split_scomm.c
131909c
@mtei
add some comment to serial.c
6327d1a
@mtei
add some comment about SELECT_SOFT_SERIAL_SPEED
5dbd74a
@drashna
Copy link
Member

drashna commented Oct 22, 2018

Thanks!

@drashna drashna merged commit 4665e4f into qmk:master Oct 22, 2018
@mtei mtei mentioned this pull request Oct 29, 2018
Merged
@mtei mtei deleted the helix-serial_c-split_scom_c-bug-fix-and-update branch October 30, 2018 11:22
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Nov 3, 2018
@mtei @zer09
Keyboard: Helix serial.c, split_scom.c bug fix and update (qmk#4191)
b076b62 
* helix/serial.c add support PD1,PD3,PE6 and configuration simplify

* Add comment about ATmega32U4 I2C

* Add compile time check for ATmega32U4 I2C

* change TAB code to 8 SPACE code

* Helix serial.c PORTD,PD0 test. OK

  OK PD0
  -  PD1
  OK PD2
  -  PD3
  -  PE6

* Helix serial.c PORTD,PD1 test. OK

   OK PD0
   OK PD1
   OK PD2
   -  PD3
   -  PE6

* Helix serial.c PORTD,PD3 test. OK

   OK PD0
   OK PD1
   OK PD2
   OK PD3
   -  PE6

* Helix serial.c PORTE,PD6 test. OK

   OK PD0
   OK PD1
   OK PD2
   OK PD3
   OK PE6

* Helix serial.c: PD0,PD1,PD3,PE6 all test end

* Helix serial.c: rename SOFT_SERIAL_PORT to SOFT_SERIAL_PIN

* Helix serial.c add debug code

* Helix serial.c: add transaction ID range check

* Helix serial.c debug code update

* Helix serial.c debug code update

* Helix serial.c: Strict checking of the value of tid.

* adjust the delay of serial.c

* Helix serial.c: remove debug code

* remove EXTRAFLAGS += -DCONSOLE_ENABLE from five_rows/rules.mk

tmk_core/common.mk has
 >ifeq ($(strip $(CONSOLE_ENABLE)), yes)
 >   TMK_COMMON_DEFS += -DCONSOLE_ENABLE

* Fix error handling in split_scomm.c

* add some comment to serial.c

* add some comment about SELECT_SOFT_SERIAL_SPEED
3n4rKy pushed a commit to 3n4rKy/qmk_firmware that referenced this pull request Nov 4, 2018
@mtei
Keyboard: Helix serial.c, split_scom.c bug fix and update (qmk#4191)
6bcfcb9 
* helix/serial.c add support PD1,PD3,PE6 and configuration simplify

* Add comment about ATmega32U4 I2C

* Add compile time check for ATmega32U4 I2C

* change TAB code to 8 SPACE code

* Helix serial.c PORTD,PD0 test. OK

  OK PD0
  -  PD1
  OK PD2
  -  PD3
  -  PE6

* Helix serial.c PORTD,PD1 test. OK

   OK PD0
   OK PD1
   OK PD2
   -  PD3
   -  PE6

* Helix serial.c PORTD,PD3 test. OK

   OK PD0
   OK PD1
   OK PD2
   OK PD3
   -  PE6

* Helix serial.c PORTE,PD6 test. OK

   OK PD0
   OK PD1
   OK PD2
   OK PD3
   OK PE6

* Helix serial.c: PD0,PD1,PD3,PE6 all test end

* Helix serial.c: rename SOFT_SERIAL_PORT to SOFT_SERIAL_PIN

* Helix serial.c add debug code

* Helix serial.c: add transaction ID range check

* Helix serial.c debug code update

* Helix serial.c debug code update

* Helix serial.c: Strict checking of the value of tid.

* adjust the delay of serial.c

* Helix serial.c: remove debug code

* remove EXTRAFLAGS += -DCONSOLE_ENABLE from five_rows/rules.mk

tmk_core/common.mk has
 >ifeq ($(strip $(CONSOLE_ENABLE)), yes)
 >   TMK_COMMON_DEFS += -DCONSOLE_ENABLE

* Fix error handling in split_scomm.c

* add some comment to serial.c

* add some comment about SELECT_SOFT_SERIAL_SPEED
rseymour pushed a commit to rseymour/qmk_firmware that referenced this pull request Mar 13, 2019
@mtei @rseymour
Keyboard: Helix serial.c, split_scom.c bug fix and update (qmk#4191)
9edb6a9 
* helix/serial.c add support PD1,PD3,PE6 and configuration simplify

* Add comment about ATmega32U4 I2C

* Add compile time check for ATmega32U4 I2C

* change TAB code to 8 SPACE code

* Helix serial.c PORTD,PD0 test. OK

  OK PD0
  -  PD1
  OK PD2
  -  PD3
  -  PE6

* Helix serial.c PORTD,PD1 test. OK

   OK PD0
   OK PD1
   OK PD2
   -  PD3
   -  PE6

* Helix serial.c PORTD,PD3 test. OK

   OK PD0
   OK PD1
   OK PD2
   OK PD3
   -  PE6

* Helix serial.c PORTE,PD6 test. OK

   OK PD0
   OK PD1
   OK PD2
   OK PD3
   OK PE6

* Helix serial.c: PD0,PD1,PD3,PE6 all test end

* Helix serial.c: rename SOFT_SERIAL_PORT to SOFT_SERIAL_PIN

* Helix serial.c add debug code

* Helix serial.c: add transaction ID range check

* Helix serial.c debug code update

* Helix serial.c debug code update

* Helix serial.c: Strict checking of the value of tid.

* adjust the delay of serial.c

* Helix serial.c: remove debug code

* remove EXTRAFLAGS += -DCONSOLE_ENABLE from five_rows/rules.mk

tmk_core/common.mk has
 >ifeq ($(strip $(CONSOLE_ENABLE)), yes)
 >   TMK_COMMON_DEFS += -DCONSOLE_ENABLE

* Fix error handling in split_scomm.c

* add some comment to serial.c

* add some comment about SELECT_SOFT_SERIAL_SPEED
yamad pushed a commit to yamad/qmk_firmware that referenced this pull request Apr 10, 2019
@mtei @yamad
Keyboard: Helix serial.c, split_scom.c bug fix and update (qmk#4191)
6eabcc6 
* helix/serial.c add support PD1,PD3,PE6 and configuration simplify

* Add comment about ATmega32U4 I2C

* Add compile time check for ATmega32U4 I2C

* change TAB code to 8 SPACE code

* Helix serial.c PORTD,PD0 test. OK

  OK PD0
  -  PD1
  OK PD2
  -  PD3
  -  PE6

* Helix serial.c PORTD,PD1 test. OK

   OK PD0
   OK PD1
   OK PD2
   -  PD3
   -  PE6

* Helix serial.c PORTD,PD3 test. OK

   OK PD0
   OK PD1
   OK PD2
   OK PD3
   -  PE6

* Helix serial.c PORTE,PD6 test. OK

   OK PD0
   OK PD1
   OK PD2
   OK PD3
   OK PE6

* Helix serial.c: PD0,PD1,PD3,PE6 all test end

* Helix serial.c: rename SOFT_SERIAL_PORT to SOFT_SERIAL_PIN

* Helix serial.c add debug code

* Helix serial.c: add transaction ID range check

* Helix serial.c debug code update

* Helix serial.c debug code update

* Helix serial.c: Strict checking of the value of tid.

* adjust the delay of serial.c

* Helix serial.c: remove debug code

* remove EXTRAFLAGS += -DCONSOLE_ENABLE from five_rows/rules.mk

tmk_core/common.mk has
 >ifeq ($(strip $(CONSOLE_ENABLE)), yes)
 >   TMK_COMMON_DEFS += -DCONSOLE_ENABLE

* Fix error handling in split_scomm.c

* add some comment to serial.c

* add some comment about SELECT_SOFT_SERIAL_SPEED
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtei @drashna