Swapped Row and Column in comments #4247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When comparing the pins in this file to the Ergodox Infinity schematic, it seems that the first section is describing the rows and the second section is describing the columns.
|
Travis CI errors are unrelated to this change. Thanks! |
Dannzzor
added a commit
to Dannzzor/qmk_firmware
that referenced
this pull request
Oct 28, 2018
* upstream/master: (1215 commits) Add Bootmagic Lite to QMK (qmk#4215) Keymap: update keymap transmogrified (qmk#4241) Keyboard: Redox keymaps refactoring (qmk#4258) Keymap: Personal dz60 keymap (qmk#4251) Keymap: add my planck rev 5 layout (qmk#4085) Redox Wireless configurator support (qmk#4256) Keyboard: Add new keyboard Zinc (qmk#4245) Docs: Add references to One Shot functions, and clean up formatting (qmk#4189) Add caveat for basic keycodes in Tap Dance docs Add delayed flashing option for DFU Util (qmk#4225) RGB Support for Panc60 (qmk#4253) Add key caveat to combos doc Fix mouse_send() on chibiOS so it won't lock up the firmware Keymap: Update userspace (I want my Hacktoberfest shirt!) (qmk#4252) Keyboard: Add HS60 V2 (qmk#4250) add better example add support for encoders to core Ergodox Infinity: Swapped Row and Column in comments (qmk#4247) JD45: readme update JD45: mjt6u keymap refactor ...
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Nov 3, 2018
When comparing the pins in this file to the Ergodox Infinity schematic, it seems that the first section is describing the rows and the second section is describing the columns.
3n4rKy
pushed a commit
to 3n4rKy/qmk_firmware
that referenced
this pull request
Nov 4, 2018
When comparing the pins in this file to the Ergodox Infinity schematic, it seems that the first section is describing the rows and the second section is describing the columns.
djthread
pushed a commit
to djthread/qmk_firmware
that referenced
this pull request
Jan 9, 2019
When comparing the pins in this file to the Ergodox Infinity schematic, it seems that the first section is describing the rows and the second section is describing the columns.
rseymour
pushed a commit
to rseymour/qmk_firmware
that referenced
this pull request
Mar 13, 2019
When comparing the pins in this file to the Ergodox Infinity schematic, it seems that the first section is describing the rows and the second section is describing the columns.
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
When comparing the pins in this file to the Ergodox Infinity schematic, it seems that the first section is describing the rows and the second section is describing the columns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing the pins in this file to the Ergodox Infinity schematic, it seems that the first section is describing the rows and the second section is describing the columns.