Refactor Helix keymap 'five_rows' #4676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
ishtob
pushed a commit
to ishtob/qmk_firmware
that referenced
this pull request
Jan 1, 2019
…r easy maintenance. (qmk#4676)
yeliu84
pushed a commit
to yeliu84/qmk_firmware
that referenced
this pull request
Jan 7, 2019
…r easy maintenance. (qmk#4676)
rseymour
pushed a commit
to rseymour/qmk_firmware
that referenced
this pull request
Mar 13, 2019
…r easy maintenance. (qmk#4676)
djthread
pushed a commit
to djthread/qmk_firmware
that referenced
this pull request
Mar 17, 2019
…r easy maintenance. (qmk#4676)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed
keyboards/helix/rev2/keymaps/five_rows/keymap.cto use theLAYOUT_kc()macro instead of theLAYOUT()macro for ease of maintenance.This request does not change the compilation results.
Types of changes
Checklist: