Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add personal userspace, update keymaps #4845

Merged
merged 13 commits into from
Jan 14, 2019

Conversation

vomindoraan
Copy link
Contributor

@vomindoraan vomindoraan commented Jan 14, 2019

Move common features of my keymaps into a userspace (finally).
Change how shared Fn and Numpad layers work.

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@@ -0,0 +1,16 @@
BOOTMAGIC_ENABLE = no
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no? Not even lite?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really dislike the Bootmagic user experience, Command is a great alternative for me 😃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also with lite I'm kind of scared of accidentally putting the board into bootloader mode when holding it and plugging it in.

@mechmerlin
Copy link
Contributor

LGTM

@mechmerlin mechmerlin merged commit 9105bf2 into qmk:master Jan 14, 2019
loadedsith added a commit to loadedsith/qmk_firmware that referenced this pull request Jan 15, 2019
* master: (759 commits)
  [Keyboard] Add cKeys Handwire 101 Keyboard (qmk#4848)
  [Keyboard] Iris via support, Rev 3 updates (qmk#4849)
  [Keyboard] Add bthlabs/geekpad (qmk#4840)
  [Keymap] Added resfury keymap (qmk#4827)
  Pointed LM Docs at expected keycodes (qmk#4835)
  Add personal userspace, update keymaps (qmk#4845)
  [Keyboard] Add support for THE50 (qmk#4844)
  Change handling of CUSTOM_MATRIX in common_features.mk slightly.
  Modified URLs to point to new locations
  [Keymap] Nyquist layout adapted from eorgodox_ez:skug (qmk#4830)
  [Keymap] Adds keymaps for muzfuz DZ60, Planck, Clueboard66 (qmk#4825)
  Changed rest note (qmk#4837)
  [Keymap] Add tw1t611 german keyboard layout for minidox. (qmk#4679)
  [Keyboard] hexon38 and Dual-role key implementation (qmk#4709)
  [Keymap] my keymap for the crkbd and update my iris keymap readme (qmk#4788)
  [Keymap] Update to personal keymaps and userspace (qmk#4831)
  [Keyboard] Fix layout macro name for Gergo info.json (qmk#4828)
  Remove empty action_function()
  Remove empty fn_actions[]
  [Keyboard] Adding support for Gergo (qmk#4792)
  ...
rseymour pushed a commit to rseymour/qmk_firmware that referenced this pull request Mar 13, 2019
* Add kbd6x:konstantin keymap

* Prevent tap dance from sending LShift as a weak mod in KBD6X

* Move config.h and rules.mk definitions into userspace

* Add UC_WIN to UNICODE_SELECTED_MODES

* Temporarily use Bootmagic until Command is fixed

* Move common behavior from keyboards into userspace

* Update kbd6x:konstantin keymap and userspace

* Make a RCTRL layer in kbd6x:konstantin

* Make KC_ESC turn off layers

* KC_ESC turns L_FN off only if it was locked on

* Add missing record->event.pressed checks

* Move numpad toggling logic into function

* Disable Bootmagic, enable KEYBOARD_SHARED_EP with Command
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
* Add kbd6x:konstantin keymap

* Prevent tap dance from sending LShift as a weak mod in KBD6X

* Move config.h and rules.mk definitions into userspace

* Add UC_WIN to UNICODE_SELECTED_MODES

* Temporarily use Bootmagic until Command is fixed

* Move common behavior from keyboards into userspace

* Update kbd6x:konstantin keymap and userspace

* Make a RCTRL layer in kbd6x:konstantin

* Make KC_ESC turn off layers

* KC_ESC turns L_FN off only if it was locked on

* Add missing record->event.pressed checks

* Move numpad toggling logic into function

* Disable Bootmagic, enable KEYBOARD_SHARED_EP with Command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants