Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add numpad_5x6 layout support for Prime M keyboard #5149

Merged
merged 2 commits into from
Feb 17, 2019
Merged

Add numpad_5x6 layout support for Prime M keyboard #5149

merged 2 commits into from
Feb 17, 2019

Conversation

drashna
Copy link
Member

@drashna drashna commented Feb 16, 2019

Description

Add numpad_5x6 community layout, and add support for it to Prime M pad.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna added the keymap label Feb 17, 2019
mechmerlin
mechmerlin approved these changes Feb 17, 2019
View reviewed changes
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mechmerlin mechmerlin merged commit 1622627 into qmk:master Feb 17, 2019
@drashna drashna deleted the keyboard/prime_m branch February 19, 2019 05:38
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Mar 2, 2019
@drashna @zer09
Add numpad_5x6 layout support for Prime M keyboard (qmk#5149)
7cc6171 
* Add numpad_5x6 layout support for Prime M keyboard

* fix default layout
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
@drashna
Add numpad_5x6 layout support for Prime M keyboard (qmk#5149)
78a74a2 
* Add numpad_5x6 layout support for Prime M keyboard

* fix default layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mechmerlin mechmerlin mechmerlin approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drashna @mechmerlin