Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add jotanck keyboard #5192

Merged
merged 14 commits into from Feb 21, 2019
Merged

add jotanck keyboard #5192

merged 14 commits into from Feb 21, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 20, 2019

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

noroadsleft
noroadsleft requested changes Feb 20, 2019
View reviewed changes
keyboards/jotanck/config.h Outdated Show resolved Hide resolved
keyboards/jotanck/config.h Outdated Show resolved Hide resolved
@noroadsleft
Copy link
Member

Default keymap compiles.

Travis CI errors are:

  • bakingpy, symbolic and wanleg community keymaps all define a custom TAPPING_TERM, which is already defined at keyboard-level here.
  • xyverz community keymap fails because it's trying to compile with RGBLIGHT_ENABLE = yes, but the keyboard doesn't support the feature.

Additionally, @jotix, handwired projects should go in keyboards/handwired.

drashna
drashna requested changes Feb 20, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've flagged a few things that we'd like to see changed, to keep everything consistent with our coding conventions, and some issues/redundant code.

keyboards/jotanck/config.h Outdated Show resolved Hide resolved
keyboards/jotanck/config.h Outdated Show resolved Hide resolved
keyboards/jotanck/config.h Outdated Show resolved Hide resolved
keyboards/jotanck/config.h Outdated Show resolved Hide resolved
keyboards/jotanck/jotanck.h Outdated Show resolved Hide resolved
keyboards/jotanck/jotanck.h Outdated Show resolved Hide resolved
keyboards/jotanck/jotanck.h Outdated Show resolved Hide resolved
keyboards/jotanck/jotanck.h Outdated Show resolved Hide resolved
@drashna
Copy link
Member

drashna commented Feb 20, 2019

Travis CI errors are unrelated, and due to layout support

noroadsleft and others added 8 commits February 20, 2019 18:18
@noroadsleft
Update keyboards/jotanck/config.h
06d5e2f 
Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>
@drashna
Update keyboards/jotanck/config.h
0514203 
Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>
@drashna
Update keyboards/jotanck/config.h
7429f9a 
Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>
@drashna
Update keyboards/jotanck/config.h
775728e 
Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>
@drashna
Update keyboards/jotanck/jotanck.h
0d33c77 
Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>
@drashna
Update keyboards/jotanck/jotanck.h
cd24e29 
Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>
@drashna
Update keyboards/jotanck/jotanck.h
7f30b81 
Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>
requested changes
25e91d1
@ghost
Copy link
Author

ghost commented Feb 20, 2019

I think I made all the changes that you suggested to me

@ghost
Copy link
Author

ghost commented Feb 21, 2019

I think now is ok?

@drashna
Copy link
Member

drashna commented Feb 21, 2019

Looks good to me!

@drashna drashna merged commit 0c607f8 into qmk:master Feb 21, 2019
@ghost ghost deleted the jotanck branch February 26, 2019 13:27
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Mar 2, 2019
@zer09
[Keyboard] add jotanck keyboard (qmk#5192)
e1f1244 
* add jotanck keyboard

* Update keyboards/jotanck/config.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/config.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/config.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/config.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/jotanck.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/jotanck.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/jotanck.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* requested changes

* Update keyboards/handwired/jotanck/readme.md

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* add backlight support

* add default keymap image to readme

* add default keymap image to readme
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Mar 7, 2019
@slugger7
[Keyboard] add jotanck keyboard (qmk#5192)
f9ec909 
* add jotanck keyboard

* Update keyboards/jotanck/config.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/config.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/config.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/config.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/jotanck.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/jotanck.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/jotanck.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* requested changes

* Update keyboards/handwired/jotanck/readme.md

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* add backlight support

* add default keymap image to readme

* add default keymap image to readme
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Apr 3, 2019
@slugger7
[Keyboard] add jotanck keyboard (qmk#5192)
e71fb22 
* add jotanck keyboard

* Update keyboards/jotanck/config.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/config.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/config.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/config.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/jotanck.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/jotanck.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/jotanck.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* requested changes

* Update keyboards/handwired/jotanck/readme.md

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* add backlight support

* add default keymap image to readme

* add default keymap image to readme
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
[Keyboard] add jotanck keyboard (qmk#5192)
dadc02a 
* add jotanck keyboard

* Update keyboards/jotanck/config.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/config.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/config.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/config.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/jotanck.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/jotanck.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* Update keyboards/jotanck/jotanck.h

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* requested changes

* Update keyboards/handwired/jotanck/readme.md

Co-Authored-By: jotix <47826561+jotix@users.noreply.github.com>

* add backlight support

* add default keymap image to readme

* add default keymap image to readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noroadsleft @drashna