Reduce tetris firmware size by disabling default audio #5197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Mar 2, 2019
slugger7
pushed a commit
to slugger7/qmk_firmware
that referenced
this pull request
Mar 7, 2019
slugger7
pushed a commit
to slugger7/qmk_firmware
that referenced
this pull request
Apr 3, 2019
dlhextall
pushed a commit
to dlhextall/qmk_firmware
that referenced
this pull request
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
tetris:defaultkeymap rests just a few bytes below its maximum, such that even small overheads of new features (e.geeconfigadditions) push it over the limit.Disabling default audio for this keyboard frees up a few thousand bytes while allowing those that want it to easily re-enable it.
The keyboard owner @YCF may also make additional size updates further on.
Types of Changes