Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rgblight_effect_breathing interval time #5213

Merged
merged 1 commit into from
Feb 22, 2019
Merged

fix rgblight_effect_breathing interval time #5213

merged 1 commit into from
Feb 22, 2019

Conversation

mtei
Copy link
Contributor

@mtei mtei commented Feb 22, 2019

Changed RGBLED_RAINBOW_SWIRL_INTERVALS in rgblight_effect_breathing () to RGBLED_BREATHING_INTERVALS.

@chrislewisdev
I think this is a simple careless mistake. Is this correct?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@chrislewisdev
Copy link
Contributor

Good spot! I must have accidentally copy-pasted that value in while doing a little refactoring. Thanks for fixing it up :)

mechmerlin
mechmerlin approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mechmerlin mechmerlin merged commit e3621c1 into qmk:master Feb 22, 2019
@mtei mtei deleted the fix_rgblight.c_EFFECT_BREATHING_interval branch February 22, 2019 17:11
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Mar 2, 2019
@mtei @zer09
fix rgblight_effect_breathing interval time (qmk#5213)
4127668
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Mar 7, 2019
@mtei @slugger7
fix rgblight_effect_breathing interval time (qmk#5213)
441b374
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Apr 3, 2019
@mtei @slugger7
fix rgblight_effect_breathing interval time (qmk#5213)
c230e87
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
@mtei
fix rgblight_effect_breathing interval time (qmk#5213)
a4b087c
hogashi pushed a commit to hogashi/qmk_firmware that referenced this pull request Apr 18, 2020
@mtei @hogashi
fix rgblight_effect_breathing interval time (qmk#5213)
176203d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislewisdev chrislewisdev chrislewisdev approved these changes

@mechmerlin mechmerlin mechmerlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtei @chrislewisdev @mechmerlin