Ask for your name when generating a new keyboard #5214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
changed the title
|
#5191 would make this obsolete, correct? |
drashna
requested review from
mechmerlin,
jackhumbert,
drashna,
ezuk,
fredizzimo and
skullydazed
|
Indeed. This can be closed if you're aiming to merge that instead. |
mechmerlin
requested changes
Feb 25, 2019
Co-Authored-By: fauxpark <fauxpark@gmail.com>
slugger7
pushed a commit
to slugger7/qmk_firmware
that referenced
this pull request
Mar 7, 2019
* Ask for your name when generating a new keyboard * Update docs * Apply suggestions from code review Co-Authored-By: fauxpark <fauxpark@gmail.com>
dstrelau
pushed a commit
to dstrelau/qmk_firmware
that referenced
this pull request
Mar 18, 2019
* master: (1214 commits) [Keyboard] Add configurator support for 40percentclub/half_n_half (qmk#5260) Bucktooth 2.0 key layout for Preonic (qmk#5258) [Keymap] Hs60 win osx dual (qmk#5249) Added a numpad keymap for the vitamins included keyboard (qmk#5247) [Keymap] Converted stanrc85 community layout to userspace (qmk#5244) LAYOUT_ortho_4x4 (qmk#5257) Ask for your name when generating a new keyboard (qmk#5214) [Keymap] nstickney's layout for iris (qmk#5045) [Keymap] adding my Levinson keymap (qmk#5177) [Keymap] HS60 v2 keymap updates (qmk#5250) [Keyboard] Added Boardwalk keyboard (qmk#5195) [Keymap] Balance Twelve-based layout for Niu Mini (qmk#5228) [Keyboard] Initial refactor of maxipad to conform to current standards (qmk#5233) handwired/magicforce68: refactor, Configurator support, and readme cleanup (qmk#5234) [Keymap] HS60 v2 ISO layout andys8 (qmk#5235) Some minor refactoring of boards in 1upkeyboards directory (qmk#5236) Fix pinout for Quefrency left half w/macros [Keyboard] KBDFans Minor Fixes (qmk#5238) [Keyboard] Hecomi conf (qmk#5246) Corrected HS60 v2 keyboard name in info.json (qmk#5242) ...
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Mar 18, 2019
* Ask for your name when generating a new keyboard * Update docs * Apply suggestions from code review Co-Authored-By: fauxpark <fauxpark@gmail.com>
chie4hao
pushed a commit
to chie4hao/qmk_firmware
that referenced
this pull request
Mar 28, 2019
* Ask for your name when generating a new keyboard * Update docs * Apply suggestions from code review Co-Authored-By: fauxpark <fauxpark@gmail.com>
slugger7
pushed a commit
to slugger7/qmk_firmware
that referenced
this pull request
Apr 3, 2019
* Ask for your name when generating a new keyboard * Update docs * Apply suggestions from code review Co-Authored-By: fauxpark <fauxpark@gmail.com>
dlhextall
pushed a commit
to dlhextall/qmk_firmware
that referenced
this pull request
May 24, 2019
* Ask for your name when generating a new keyboard * Update docs * Apply suggestions from code review Co-Authored-By: fauxpark <fauxpark@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the keyboard generator script decides what your name is for you. Now it will ask :^)
REPLACE_WITH_YOUR_NAMEhas been changed to%YOUR_NAME%and will be substituted in:MANUFACTURER)Types of Changes
Issues Fixed or Closed by This PR
Checklist