-
-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rgblight.c: add remap feature #5243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gblight.c:RGBLIGHT_LED_MAP
…config.h to test rgblight.c:RGBLIGHT_LED_MAP" This reverts commit e7488d6.
drashna
approved these changes
Feb 26, 2019
drashna
requested review from
mechmerlin,
jackhumbert,
ezuk,
fredizzimo and
skullydazed
February 26, 2019 00:04
XScorpion2
suggested changes
Feb 26, 2019
XScorpion2
approved these changes
Feb 27, 2019
13 tasks
mechmerlin
approved these changes
Mar 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
chie4hao
pushed a commit
to chie4hao/qmk_firmware
that referenced
this pull request
Mar 28, 2019
* rgblight.c: add RGBLIGHT_LED_MAP support * add code to keyboards/helix/rev2/keymaps/five_rows/config.h to test rgblight.c:RGBLIGHT_LED_MAP * Test end. Revert "add code to keyboards/helix/rev2/keymaps/five_rows/config.h to test rgblight.c:RGBLIGHT_LED_MAP" This reverts commit e7488d6. * update docs/feature_rgblight.md * led_map[] move to PROGMEM
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Mar 31, 2019
* rgblight.c: add RGBLIGHT_LED_MAP support * add code to keyboards/helix/rev2/keymaps/five_rows/config.h to test rgblight.c:RGBLIGHT_LED_MAP * Test end. Revert "add code to keyboards/helix/rev2/keymaps/five_rows/config.h to test rgblight.c:RGBLIGHT_LED_MAP" This reverts commit e7488d6. * update docs/feature_rgblight.md * led_map[] move to PROGMEM
danielo515
pushed a commit
to danielo515/qmk_firmware
that referenced
this pull request
May 15, 2019
* rgblight.c: add RGBLIGHT_LED_MAP support * add code to keyboards/helix/rev2/keymaps/five_rows/config.h to test rgblight.c:RGBLIGHT_LED_MAP * Test end. Revert "add code to keyboards/helix/rev2/keymaps/five_rows/config.h to test rgblight.c:RGBLIGHT_LED_MAP" This reverts commit e7488d6. * update docs/feature_rgblight.md * led_map[] move to PROGMEM
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
* rgblight.c: add RGBLIGHT_LED_MAP support * add code to keyboards/helix/rev2/keymaps/five_rows/config.h to test rgblight.c:RGBLIGHT_LED_MAP * Test end. Revert "add code to keyboards/helix/rev2/keymaps/five_rows/config.h to test rgblight.c:RGBLIGHT_LED_MAP" This reverts commit e7488d6. * update docs/feature_rgblight.md * led_map[] move to PROGMEM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for
RGBLIGHT_LED_MAP
macro to rgblight.c.Example 1:
Example 2:
On a keyboard that uses the RGB LEDs as a backlight for each key, this macro helps to light the corresponding LED when the key is pressed.
Types of Changes
Checklist