Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate keymaps to VIA enabled/dissabled. #5302

Merged
merged 2 commits into from
Mar 4, 2019
Merged

Separate keymaps to VIA enabled/dissabled. #5302

merged 2 commits into from
Mar 4, 2019

Conversation

yiancar
Copy link
Contributor

@yiancar yiancar commented Mar 3, 2019

  • Default rules.mk has been changed to disable via.
  • VIA keymaps have been added for default keymaps.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@yiancar
Separate keymaps to VIA enabled/dissabled.
b40f593 
- Default rules.mk has been changed to disable via.
- VIA keymaps have been added for default keymaps.
@wilba
Copy link
Contributor

wilba commented Mar 3, 2019

@yiancar I recommended in your situation (three different layouts/devices implemented as one), the keymap name ends in _via so the built .hex will always end in _via. Thus iso_via, ansi_via, hhkb_via. This can then continue as a naming scheme for others to add their own, like iso_andys8

@yiancar
Copy link
Contributor Author

yiancar commented Mar 3, 2019

ok cool moving the via the other way round

mechmerlin
mechmerlin approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mechmerlin mechmerlin merged commit 7bfe087 into qmk:master Mar 4, 2019
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Mar 7, 2019
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
2b95a03 
* 'master' of https://github.com/qmk/qmk_firmware: (76 commits)
  [Keyboard] Adds Gray Studio HB85 Initial Support (qmk#5311)
  [Keymap] Add KC_MAKE keycode to my userspace and keymaps (qmk#5324)
  [Keyboard] handwired/trackpoint: refactor and readme cleanup (qmk#5325)
  [Keyboard] re-arrange the pinout for backlight support (qmk#5321)
  [Keymap] update: simplify tapdance code for Minidox/keymaps/dustypomerleau (qmk#5315)
  [Keymap] Add vxid planck layout (qmk#5271)
  increase size of note counter variable to avoid overflow
  Adopted LAYOUT, added some keys (qmk#5320)
  Add more "decent" text editors (qmk#5308)
  Add DZ60 Tsangan Layout + Fn layer (qmk#5319)
  [Docs] Fix function signature (layer_state_set_*) (qmk#5313)
  Correct keyboard and layout dimensions for 40percent.club Foobar (qmk#5310)
  Dactyl Manuform 5x6, 5x7, and 6x6: QMK Configurator fixes and partial code clean-up (qmk#5307)
  Fixed default to dissable VIA (qmk#5309)
  Clean up debounce a bit (qmk#5255)
  Fix aanzee Configurator config file (qmk#5286)
  Separate keymaps to VIA enabled/dissabled. (qmk#5302)
  [Keymap] Add RGB config and controls to userspace (qmk#5299)
  Add LED Matrix to Features list for easy reference (qmk#5280)
  [Keymap] layout/community/ortho4x12/symbolic update (qmk#5274)
  ...
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Mar 7, 2019
@yiancar @slugger7
Separate keymaps to VIA enabled/dissabled. (qmk#5302)
064a1b3 
* Separate keymaps to VIA enabled/dissabled.

- Default rules.mk has been changed to disable via.
- VIA keymaps have been added for default keymaps.

* Update naming
@yiancar yiancar deleted the HS60v2_via_keymaps branch March 12, 2019 22:12
chie4hao pushed a commit to chie4hao/qmk_firmware that referenced this pull request Mar 28, 2019
@yiancar @chie4hao
Separate keymaps to VIA enabled/dissabled. (qmk#5302)
bbdcd1a 
* Separate keymaps to VIA enabled/dissabled.

- Default rules.mk has been changed to disable via.
- VIA keymaps have been added for default keymaps.

* Update naming
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Mar 31, 2019
@yiancar @zer09
Separate keymaps to VIA enabled/dissabled. (qmk#5302)
65e2e75 
* Separate keymaps to VIA enabled/dissabled.

- Default rules.mk has been changed to disable via.
- VIA keymaps have been added for default keymaps.

* Update naming
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Apr 3, 2019
@yiancar @slugger7
Separate keymaps to VIA enabled/dissabled. (qmk#5302)
85ba35d 
* Separate keymaps to VIA enabled/dissabled.

- Default rules.mk has been changed to disable via.
- VIA keymaps have been added for default keymaps.

* Update naming
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
@yiancar
Separate keymaps to VIA enabled/dissabled. (qmk#5302)
e8b397e 
* Separate keymaps to VIA enabled/dissabled.

- Default rules.mk has been changed to disable via.
- VIA keymaps have been added for default keymaps.

* Update naming
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@yiancar @Timbus
Separate keymaps to VIA enabled/dissabled. (qmk#5302)
f1553ec 
* Separate keymaps to VIA enabled/dissabled.

- Default rules.mk has been changed to disable via.
- VIA keymaps have been added for default keymaps.

* Update naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mechmerlin mechmerlin mechmerlin approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yiancar @wilba @mechmerlin