Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mekanist DZ60rgb Keymap #5335

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Mar 7, 2019

Description

Checking in @nshanpetrosyan (mekanist) keymap so he can retain all his functionality and easily edit it on his own. Special thanks to @MatthewRobo for helping create the layer rgb lightings.

I've included a helpful readme.md as well.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@race41989
Copy link

race41989 commented Mar 7, 2019

Is this a potential fix to the Configurator compile error?

@mechmerlin
Copy link
Contributor Author

mechmerlin commented Mar 8, 2019

Is this a potential fix to the Configurator compile error?

tl;dr: @race41989 no it is not. This is a keymap for mekanist's keyboard that has a bunch of his features that I've been helping him with. Mekanist is a member of the community who I've been chatting with for awhile and I figured I'd help him do this.

Creating a firmware file for your keyboard can be done in 2 different ways. The first is via the online GUI known as QMK Configurator. The second way is to compile the source code yourself with the keymap and functionality you want. This PR was specifically made to assist mekanist in compiling the source himself with his keymap and desired functionality. It has nothing to do with the breakage in QMK Configurator.

While the QMK Configurator is broken for dz60rgb, you can do what mekanist is doing here as well. You can consult our guide on how to setup a development environment and how to create your keymap from scratch.

@nshanpetrosyan
Copy link
Contributor

Thanks again for your help @mechmerlin !

@drashna
Copy link
Member

drashna commented Mar 8, 2019

Thanks!

@drashna drashna merged commit 81fae5c into qmk:master Mar 8, 2019
chie4hao pushed a commit to chie4hao/qmk_firmware that referenced this pull request Mar 28, 2019
@mechmerlin mechmerlin deleted the feature/mekanistdz60rgb branch March 29, 2019 13:27
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Mar 31, 2019
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants