Added info.json for mt980 keyboard and fixes to walker keymap

[walkerstop]

Added info.json for mt980 keyboard so configurator works on this keyboard, and fix a couple issues in keymap

[noroadsleft]

Your JSON objects are in the wrong order. This will lead to QMK Configurator assigning keycodes to the wrong locations, as-is.

See the suggestions below.

[noroadsleft]

Looks good to me. 👍

[mechmerlin]

That's very odd. @noroadsleft I gave @walkerstop your tool to convert kbfirmware.json file over. Walker, did you use it? If you did, we might have to look at that tool again.

[walkerstop]

That's very odd. @noroadsleft I gave @walkerstop your tool to convert kbfirmware.json file over. Walker, did you use it? If you did, we might have to look at that tool again.

Yep I used that tool

[noroadsleft]

That's very odd. @noroadsleft I gave @walkerstop your tool to convert kbfirmware.json file over. Walker, did you use it? If you did, we might have to look at that tool again.

Yep I used that tool

@walkerstop, any chance you could send me the JSON you put into the tool? I could use it for debugging.

I think I already know what this issue is, but I'd need an appropriate JSON file to solve it.

[walkerstop]

That's very odd. @noroadsleft I gave @walkerstop your tool to convert kbfirmware.json file over. Walker, did you use it? If you did, we might have to look at that tool again.

Yep I used that tool

@walkerstop, any chance you could send me the JSON you put into the tool? I could use it for debugging.

I think I already know what this issue is, but I'd need an appropriate JSON file to solve it.

Sure, here it is https://drive.google.com/open?id=1vfHCIwZ5Uaao3eeqXfxaPmrOfW9vGRO7

[noroadsleft]

@walkerstop @mechmerlin

K, I have a partial answer for why the info.json was out of order.

The way my tool parses/generates the code right now, every unique y value is on a different line of the generated code, so in this case, the argument in the layout macro for the Up arrow isn't on the same line as the Shift keys:

#define LAYOUT( \
  K50, K52, K53, K54, K55, K57, K58, KB8, KB7, KB5, KB4, KB3, KB6, K51, KB2, KB1, KB0, K63, \
  K40, K41, K42, K43, K44, K45, K46, K47, K48, KA8, KA7, KA5, KA4, KA3, KA6, KA2, KA1, KA0, K64, \
  K30, K31, K32, K33, K34, K35, K36, K37, K38, K98, K97, K95, K94, K84, K96, K92, K91, K90, \
  K20, K21, K22, K23, K24, K25, K26, K27, K28, K88, K87, K85, K93, K86, K82, K81, K80, \
  K10, K11, K12, K13, K14, K15, K16, K17, K18, K78, K77, K75, K74, K76, K72, K71, K70, \
  K73, \
  K00, K01, K02, K06, K08, K07, K05, K62, K61, K60, \
  K04, K03, K66  \
)

K73 is the Up arrow key, and K04, K03 and K66 are the Left, Down and Right arrows. (K74 is Right Shift, and K76 is KC_P1.)

From that code generation (ran walkerstop's linked file through the tool), the info.json output is valid, but only if the above code block is the physical layout macro.

walkerstop didn't use the generated <keyboard>.h output though, but used an output that was more in line with current convention (which is one of the outstanding issues with output from the KBFirmware-to-QMK tool). The info.json output, however, was used, and was not updated to match, which is where the mismatch happened. A "symptom" of this is that the label keys in info.json here don't match the argument identifiers in the existing mt980.h (my tool uses the same identifiers between these files; the label in the JSON is the same as the argument identifier in <keyboard>.h).

I do intend to solve this, but I've been stumped on this front for a while. My goal is that a user can dump a KBFirmware-format JSON file in, and get usable QMK code out that requires nothing more than saving the appropriate output to the appropriate file. I still at this point consider the tool to be very much in Beta.

[mechmerlin]

This is good to know for future ports, thanks @noroadsleft

[mechmerlin]

Approved!