Fixes issue #551 - ensure there's a recording to play before playing #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GUI button to play a tone
|
Perfect - thanks :) |
ryaninvents
pushed a commit
to ryaninvents/qmk_firmware
that referenced
this pull request
Aug 12, 2016
Fixes issue qmk#551 - ensure there's a recording to play before playing
BlueTufa
pushed a commit
to BlueTufa/qmk_firmware
that referenced
this pull request
Aug 6, 2021
* Default keymaps for sweet16 * Update commit hashes * Delete 1upkeyboards_sweet16_default.json Superseded by 1upkeyboards_sweet16_v1_default.json * Add 1upkeyboards/sweet16 to Exclusion List Forked to v1, v2/promicro and v2/proton_c versions.
jiaxin96
pushed a commit
to Oh-My-Mechanical-Keyboard/qmk_firmware
that referenced
this pull request
Oct 18, 2023
DOIO KB30-01: Tweak encoder resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also enables the LGUI button to play a tone
Fixes: Playing recording without recording sounds like dying cat and locks-up keyboard #551